Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team LEAF - Laneia, Elise, Amy W, Faiza #76

Open
wants to merge 308 commits into
base: master
Choose a base branch
from

Conversation

Faiza1987
Copy link

@Faiza1987 Faiza1987 commented May 10, 2019

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question Answer
Each team member: what is one thing you were primarily responsible for that you're proud of? Faiza is proud of the Nav bar and the OAuth stuff, Amy is proud of the orderitem duplication removal solution, Elise is proud of joining together the order and the orderitems, and Laneia is proud of the styling and the products
Each team member: what is one thing you were primarily responsible for that you would like targeted feedback on? Amy would like targeted feedback or orderitem validations and methods, Elise would like targeted feedback on Order, Faiza would like targeted feedback on Users and Laneia would like targeted feedback on Product model and controller, and the CSS.
How did your team break up the work to be done? We broke it up by model and controllers and then people picked Trello cards gthey wanted to work on.
How did your team utilize git to collaborate? We created branches, merged master into our branches and did PRs
What did your group do to try to keep your code DRY while many people collaborated on it? We never reviewed our own pull requests and no one worked on the same thing so there was no overlap.
What was a technical challenge that you faced as a group? The shopping cart saga and connecting all the models together
What was a team/personal challenge that you faced as a group? How to work with someone 3000 miles away,
What was your application's ERD? (include a link) https://drive.google.com/file/d/1Wn6dUItPx4K-wXJ_oT_uQGbKOnrHaS4V/view?usp=sharing
What is your Trello URL? https://trello.com/b/VR8l11P1/team-leaf-top-secret
What is the Heroku URL of your deployed application? https://tricksy.herokuapp.com/

laneia and others added 30 commits May 5, 2019 10:27
…provider being github and invalid data being used to log in
Added tests for redirecting if provider is not github and if given an invalid use
ChubbyCub and others added 30 commits May 10, 2019 11:06
out of stock hides add to cart and shows out of stock in quantity
on the wrong branch trying to fix the order confirmation page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants