Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make most chemical reactions instantaneous. #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PetMudstone
Copy link
Contributor

About The Pull Request

Title. This PR makes the vast majority of chemical reactions instantaneous by overriding the reaction_flag variable of most reactions to be REACTION_INSTANT.

In practice this means:

  • Almost all reactions are instant now, ignoring the fermichem gradual reaction system. This also makes mixing for particular chems much easier.
  • Almost all mixed chems always come out 100% pure now, which honestly greatly affects game balance due to fermichem buffing a lot of chems. I'll need to cover re-balancing in the future.

Basically this means mixing chems takes a lot less time and is significantly easier due to failed chems and heat concerns being a non-factor.
This also means that information about pH and impure chems and such is now bloat information in the reaction search.

Why It's Good For The Game

Fermichem has a series of issues that I and others have noticed, some of which I believe cannot be fixed by changing variables around.

First is that fermichem is hard to grasp for people unfamiliar with it. Stuff like purity, pH, reaction rates, impure chems, etc. don't make sense to players unless they are taught about it all extensively. It isn't hard to understand once you know a bit about all these concepts but it's mind boggling before that. And even after there's stuff that's just not explained in game such as H+ consuming or producing reactions and reactions like tirimol needing oxygen to be stabilized lest it cause absurdly rapid pH drops.

Second is that fermichem is tedious. For me at least and quite a few others, it just makes chemistry more frustrating to play. You have to spend time figuring out the best way to perform a reaction or hell, just to perform the reaction at all (looking at you lipidocide).
After that you're just spending time redoing the same recipes over and over like before, but now you have to constantly move chems in and out of beakers. Either buffers or the products of other reactions now that you can't just perform multiple reactions in one container without risking impurity. It just massively slows down the chem making process while making it annoying.

Changelog

🆑
balance: Made all chemical reactions instantaneous.
del: Practically removed the fermichem system by making all reactions instantaneous.
/:cl:

@github-actions
Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 5 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale label Mar 17, 2022
@github-actions github-actions bot closed this Mar 22, 2022
@comradef191 comradef191 reopened this Mar 22, 2022
@comradef191 comradef191 removed the Stale label Mar 25, 2022
@github-actions
Copy link

github-actions bot commented Apr 2, 2022

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 5 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale label Apr 2, 2022
@comradef191 comradef191 added Stale-b-gone Prevents a PR being marked as stale and removed Stale labels Apr 4, 2022
@comradef191 comradef191 added the PR Approved PR has been approved for merging label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR Approved PR has been approved for merging Stale-b-gone Prevents a PR being marked as stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants