More pretty printing fixes #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, something like the following: map (\a -> let b = a * a ; c = b * b in T2 c (T3 a b c)) (use (fromList Z [1 :: Float])) would pretty print as: map (\x0 -> let x1 = x0 * x0 x2 = x1 * x1 in T2 x2 (T3 x0 x1 x2)) (use (Scalar Z [1.0])) With this change, it is now printed as: map (\x0 -> let x1 = x0 * x0 ; x2 = x1 * x1 in T2 x2 (T3 x0 x1 x2)) (use (Scalar Z [1.0])) which is better.
This is not _necessary_ so much for prettyTuple and prettyAtuple, but it's very much wanted for prettyLhs, because it makes the code closer to parseable Haskell. Without the 'align' there, the arguments to the T<n> sometimes came on the same indentation level as the constructor, meaning they're seen as declarations in the Let due to layout rules -- which doesn't parse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes some more of my reported issues in #470. I believe these fixes work; I've tested them on small examples (including those in #470).
The semicolon change doesn't seem to be necessary for Alet, since it appears those are never put on one line.
Motivation and context
See #470 and #476.
How has this been tested?
See above; only minimalistically.
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!