New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor improve `from_config` error #191

Open

yjhmelody wants to merge 2 commits into AcalaNetwork:master from yjhmelody:chore/minor-improve

+18 −12

Contributor

yjhmelody commented Jun 20, 2024 •

edited

Loading

The outside build method will panic if return error. So we do not need to panic inside.

yjhmelody added 2 commits

June 20, 2024 17:39


          chore: return error rather than panic

e86b021


          use Self

b9bae62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet