Fix injecting block when injectable param is null #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
approved these changes
May 9, 2024
|
Thanks for the fix! |
kostekIV
added a commit
to Cardinal-Cryptography/subway
that referenced
this pull request
May 9, 2024
* Fix injecting block when injectable param is null * rm nl
kostekIV
added a commit
to Cardinal-Cryptography/subway
that referenced
this pull request
May 9, 2024
* Fix injecting block when injectable param is null * rm nl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found a problem with request caching in case when:
With that proxy will cache such requests and will use cached value for future reponses, even though when passing none we usually want to get most recent state.
To fix it I propose to inject the param also in case when injectable param in request is set to
None.cc @xlc