Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bypass cache for unfinalized blocks #154

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

ermalkaleci
Copy link
Collaborator

No description provided.

@ermalkaleci ermalkaleci requested a review from xlc March 21, 2024 14:29
@ermalkaleci ermalkaleci linked an issue Mar 21, 2024 that may be closed by this pull request
if let Some(hex_number) = number.strip_prefix("0x") {
if let Ok(number) = u64::from_str_radix(hex_number, 16) {
if number <= finalized_number {
bypass_cache = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bypass_cache = false;
context.insert(BypassCache(true));

no need bypass_cache?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be the opposite and I want to insert BypassCache only if bypass_cache is true to avoid overriding any existing BypassCache

@ermalkaleci ermalkaleci merged commit f6f076d into master Mar 22, 2024
1 check passed
@ermalkaleci ermalkaleci deleted the bypass_cache_for_latest_block branch March 22, 2024 09:07
kostekIV added a commit to Cardinal-Cryptography/subway that referenced this pull request Apr 29, 2024
* subsquid indexer & processor fix (AcalaNetwork#150)

* update deps (AcalaNetwork#155)

* bypass cache for unfinalized blocks (AcalaNetwork#154)

* endpoint health (AcalaNetwork#152)

* Await healthy endpoint (AcalaNetwork#158)

* use only tracing (AcalaNetwork#157)

* Filter call errors (AcalaNetwork#159)

* validate middleware (AcalaNetwork#156)

* validate middleware

* validate extension for config

* rename

* Improve env handling via preprocessing templated config files (AcalaNetwork#162)

* Feat(config): support ${var:-word} and ${var:+word} syntax (AcalaNetwork#164)

* fix cli default value (AcalaNetwork#169)

* improve reconnect wait time (AcalaNetwork#168)
---------

Co-authored-by: mrq1911 <[email protected]>
Co-authored-by: Ermal Kaleci <[email protected]>
Co-authored-by: Jiyuan Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve fork handling
2 participants