Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme and wiki footer with new slack, rtd, email list, license badges #1538

Conversation

maxnbk
Copy link
Contributor

@maxnbk maxnbk commented Sep 21, 2023

update readme and wiki footer with new slack, rtd, email list, license badges

@maxnbk maxnbk requested a review from a team as a code owner September 21, 2023 23:31
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of badges we have is starting to be a little bit ridiculous. I'm not convinced this PR really improves our project much.

I feel like links to the mailing list, slack, the contribution guide, etc could be added as a section of the readme. Like a "How to contribute" section, "How to contact us", etc.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@maxnbk
Copy link
Contributor Author

maxnbk commented Sep 22, 2023

The number of badges we have is starting to be a little bit ridiculous. I'm not convinced this PR really improves our project much.

I feel like links to the mailing list, slack, the contribution guide, etc could be added as a section of the readme. Like a "How to contribute" section, "How to contact us", etc.

Since the footer is part of the wiki I assumed it would retire when the wiki does.

I feel like the 8-ish CI status indicators aren't useful.

@JeanChristopheMorinPerso
Copy link
Member

Yeah, the changes to the wiki don't bother me since like you said, we will remove it soon. And yeah, the CI badges aren't useful. The idea was to show that we support all platforms, but there is better ways to do that than with badges.

@JeanChristopheMorinPerso
Copy link
Member

Umm, not sure what happened... I did a git merge main and fixed the conflict and now I see a bunch of commits from main.

@JeanChristopheMorinPerso
Copy link
Member

Alright, I have reset to the previous commit.

@JeanChristopheMorinPerso JeanChristopheMorinPerso force-pushed the 1533-update-slack-link branch 2 times, most recently from 7b699f9 to ebb3d75 Compare November 11, 2023 20:37
@JeanChristopheMorinPerso JeanChristopheMorinPerso changed the base branch from 1533-update-slack-link to main November 11, 2023 20:44
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit c3e5130 into AcademySoftwareFoundation:main Nov 11, 2023
3 checks passed
@maxnbk maxnbk linked an issue Nov 11, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update slack link
2 participants