Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/master' into loki-loggerv2
Browse files Browse the repository at this point in the history
# Conflicts:
#	VERSION.in
#	cuebot/src/main/java/com/imageworks/spcue/DispatchFrame.java
#	cuebot/src/main/java/com/imageworks/spcue/dao/postgres/DispatchQuery.java
#	cuebot/src/main/java/com/imageworks/spcue/dao/postgres/FrameDaoJdbc.java
#	proto/rqd.proto
#	requirements.txt
#	rqd/rqd/rqcore.py
  • Loading branch information
lithorus committed Nov 18, 2024
2 parents 1066e97 + 291b694 commit 6e6bf3e
Show file tree
Hide file tree
Showing 55 changed files with 2,432 additions and 1,271 deletions.
1 change: 1 addition & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
ci
!ci/fix_compiled_proto.py
cuebot/src/compiled_protobuf
images
samples
Expand Down
11 changes: 0 additions & 11 deletions .github/workflows/testing-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,6 @@ on:
branches: [ master ]

jobs:
test_python_2022:
name: Run Python Unit Tests (CY2022)
runs-on: ubuntu-22.04
container: aswf/ci-opencue:2022
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
steps:
- uses: actions/checkout@v3
- name: Run Python Tests
run: ci/run_python_tests.sh --no-gui

test_cuebot_2022:
name: Build Cuebot and Run Unit Tests (CY2022)
runs-on: ubuntu-22.04
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ venv*/
.coverage
coverage.xml
htmlcov/
rest_gateway/*.tar\.gz
/.env
.envrc
.vscode
Expand Down
2 changes: 1 addition & 1 deletion VERSION.in
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.1
1.2
1 change: 0 additions & 1 deletion ci/run_python_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ PYTHONPATH=pycue:pyoutline python -m unittest discover -s cuesubmit/tests -t cue
python -m pytest rqd/tests
python -m pytest rqd/pytests


# Xvfb no longer supports Python 2.
if [[ "$python_version" =~ "Python 3" && ${args[0]} != "--no-gui" ]]; then
ci/run_gui_test.sh
Expand Down
1 change: 1 addition & 0 deletions cueadmin/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ RUN python3 -m grpc_tools.protoc \

# Fix imports to work in both Python 2 and 3. See
# <https://github.com/protocolbuffers/protobuf/issues/1491> for more info.
COPY ci/fix_compiled_proto.py ./ci/
RUN python3 ci/fix_compiled_proto.py pycue/opencue/compiled_proto

COPY cueadmin/README.md ./cueadmin/
Expand Down
3 changes: 3 additions & 0 deletions cuebot/src/main/java/com/imageworks/spcue/DispatchFrame.java
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ public class DispatchFrame extends FrameEntity implements FrameInterface {
// A comma separated list of services
public String services;

// The Operational System this frame is expected to run in
public String os;

public boolean lokiEnabled;
public String lokiURL;
}
Expand Down
10 changes: 9 additions & 1 deletion cuebot/src/main/java/com/imageworks/spcue/DispatchHost.java
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public class DispatchHost extends Entity
public long gpuMemory;
public long idleGpuMemory;
public String tags;
public String os;
private String os;

public boolean isNimby;
public boolean isLocalDispatch = false;
Expand Down Expand Up @@ -81,6 +81,14 @@ public String getFacilityId() {
return facilityId;
}

public String[] getOs() {
return this.os.split(",");
}

public void setOs(String os) {
this.os = os;
}

public boolean canHandleNegativeCoresRequest(int requestedCores) {
// Request is positive, no need to test further.
if (requestedCores > 0) {
Expand Down
8 changes: 5 additions & 3 deletions cuebot/src/main/java/com/imageworks/spcue/VirtualProc.java
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ public String getName() {
* @param frame
* @return
*/
public static final VirtualProc build(DispatchHost host, DispatchFrame frame, String... selfishServices) {
public static final VirtualProc build(DispatchHost host,
DispatchFrame frame,
String... selfishServices) {
VirtualProc proc = new VirtualProc();
proc.allocationId = host.getAllocationId();
proc.hostId = host.getHostId();
Expand All @@ -94,7 +96,7 @@ public static final VirtualProc build(DispatchHost host, DispatchFrame frame, St
proc.jobId = frame.getJobId();
proc.showId = frame.getShowId();
proc.facilityId = frame.getFacilityId();
proc.os = host.os;
proc.os = frame.os;

proc.hostName = host.getName();
proc.unbooked = false;
Expand Down Expand Up @@ -238,7 +240,7 @@ public static final VirtualProc build(DispatchHost host,
proc.jobId = frame.getJobId();
proc.showId = frame.getShowId();
proc.facilityId = frame.getFacilityId();
proc.os = host.os;
proc.os = frame.os;

proc.hostName = host.getName();
proc.unbooked = false;
Expand Down
Loading

0 comments on commit 6e6bf3e

Please sign in to comment.