-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Adobe Photoshop and AfterEffects #2094
base: gh-pages
Are you sure you want to change the base?
Update for Adobe Photoshop and AfterEffects #2094
Conversation
Looks like the Windows version of Hugo puts out different line endings (or notice there is very little that is dark red/green). Try diff ignoring whitespace and line endings. Notice the generator changed from "Hugo -- gohugo.io" to "Hugo" |
Signed-off-by: Dave Sawyer <[email protected]>
Signed-off-by: Dave Sawyer <[email protected]>
Hmm. I think instead of altering the rendered html on the I believe if we merge a change to that file, the relevant site-building gh workflow will trigger. |
We don't have auto-generation set up for the website. You do have to commit to the gh-pages branch separately, for now. Time permitting, I'd love to get an action set up that does this auto-magically, for sure. Super weird about the line endings - I work on a Mac. If I get some time (likely won't be till this weekend) I can give it a spin and confirm suspicions. |
Ah, my mistake! Still, we need to make sure the change is reflected in supported_apps.yml in the main branch, or these changes will be lost the next time we rebuild the site... |
These changes are already in the main branch :D |
@zachlewis we thought alike. Turns out there's one more step. And it was documented. https://github.com/AcademySoftwareFoundation/OpenColorIO/tree/main/docs/site#building-the-static-website |
lol dammit zach! |
Alright, I've submitted PR #2098, which should hopefully do exactly this. Merging that PR should itself invoke a rebuild and republish of the site, which should effectively reproduce the exact changes made here. (FWIW, rebuilding the site with the latest version of Hugo seems to elicit the same differences we're seeing in here, whether invoked on a Mac locally or via an Ubuntu GH runner. I think the line-ending changes etc. are explained by the fact that the site was last built with Hugo 1.11 vs the current 1.39) |
Both have moved from plugin to native support