Adsk Contrib - Fix bit-depth attributes on inverse LUT writing to CTF format #2090
+180
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Doug Walker <[email protected]>
doug-walker
added
the
Bug
zachlewis
approved these changes
Nov 11, 2024
zachlewis
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing CTF files with inverse LUT1D or LUT3D, the in & out bit-depth attributes were swapped.
The scaling of the Array values for a forward LUT is communicated via the outBitDepth. An inverse LUT writes the same Array as the forward LUT, but the in and out depths need to be swapped. So for inverse LUTs, it's the inBitDepth that signals the Array scaling.
This PR fixes the issue, existing tests were reviewed, and new tests were added to ensure that inverse Lut1D and Lut3D are both read and written correctly with integer bit-depth settings.