Improvements to support locale, units and additional tests. #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashwinbhat
commented
Mar 29, 2022
•
ashwinbhat
commented
- Add utilities
- UnitConverterRegistry::convertToUnit
- hasNamespace
- joinStrings
- Use C Locale for string stream operations. (for Multi-language and region support autodesk-forks/MaterialX#1183)
- Add tests for unit and locale content.
kwokcb
suggested changes
Mar 31, 2022
ashwinbhat
force-pushed
the
adsk_contrib/locale_etc_to_main
branch
from
1fae076 to
665459b
Compare
- Update Document::addNodeDefFromGraph to support Namespaces - Add utilities - UnitConverterRegistry::convertToUnit - isValidNamespace - joinstring - Use C Locale for string stream operations. - Add tests for flatten, Namespaces, unit and locale content.
Minor updates to tests and remove unused headers.
ashwinbhat
force-pushed
the
adsk_contrib/locale_etc_to_main
branch
from
1d6bc3a to
6ea8d33
Compare
jstone-lucasfilm
approved these changes
Apr 19, 2022
Thanks @jstone-lucasfilm for fixing it up. Appreciate it! |
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
- Add utilities UnitConverterRegistry::convertToUnit and MaterialX::joinStrings. - Use C Locale for string stream operations (autodesk-forks#1183). - Add tests for unit and locale content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.