Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/error fix #126

Merged
merged 3 commits into from
May 19, 2024
Merged

Feature/error fix #126

merged 3 commits into from
May 19, 2024

Conversation

SeungJL
Copy link
Collaborator

@SeungJL SeungJL commented May 8, 2024

  1. 18:00이 06:00으로 표시되는 현상 수정

  2. DB에서 유저 데이터가 삭제 된 경우 클라이언트에서 null이 되기 때문에 오류가 발생하는데, 이를 방지

Copy link
Contributor

@seongbin9786 seongbin9786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

번외로 말씀드린다면

  • .filter((par) => par) 라인은 nullish 체크이면 그냥 par 대신에 !!par로 boolean으로 명시적 형변환해서 많이 쓰는 것 같습니다 :)

추가 번외로 저희 Chromatic에서 UI Tests, Review 안 쓴다면 해제해줘도 좋을 것 같습니다 :)
매번 들어가서 체크를 해주지 않으면 PR에 체크 표시가 안 뜨게 돼서 PR 상태를 쉽게 알아보기가 조금 어려운 것 같습니다 :)

@SeungJL SeungJL merged commit 948dc73 into develop May 19, 2024
2 of 4 checks passed
@SeungJL SeungJL deleted the feature/error-fix branch May 19, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants