refactor: Skeleton props 개선

AboutClan · May 6, 2024 · b0636e0 · b0636e0
1 parent f274995
commit b0636e0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/components/atoms/skeleton/Skeleton.tsx b/components/atoms/skeleton/Skeleton.tsx
@@ -1,17 +1,15 @@
-import { Skeleton as ChakraSkeleton } from "@chakra-ui/react";
+import { Skeleton as ChakraSkeleton, SkeletonProps } from "@chakra-ui/react";
+import { PropsWithChildren } from "react";
 
-interface ISkeleton {
-  children: React.ReactNode;
-  isLoad?: boolean;
-}
+interface ISkeleton extends Pick<SkeletonProps, "isLoaded"> {}
 
-function Skeleton({ children, isLoad }: ISkeleton) {
+function Skeleton({ children, isLoaded = false }: PropsWithChildren<ISkeleton>) {
   return (
     <ChakraSkeleton
       borderRadius="8px"
       startColor="RGB(227, 230, 235)"
       endColor="rgb(246,247,249)"
-      isLoaded={isLoad}
+      isLoaded={isLoaded}
       height="100%"
       width="100%"
     >

diff --git a/modals/aboutHeader/promotionModal/PromotionModalDetail.tsx b/modals/aboutHeader/promotionModal/PromotionModalDetail.tsx
@@ -23,7 +23,7 @@ function PromotionModalDetail() {
       <div>
         <span>현재 참여 수</span>
         <VoteNum>
-          <Skeleton isLoad={!isLoading}>
+          <Skeleton isLoaded={!isLoading}>
             {applyCnt || ""}명<Temp>(중복 포함)</Temp>
           </Skeleton>
         </VoteNum>