get rid of empty messages #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mentatai[bot]](https://avatars.githubusercontent.com/in/850097?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request makes a small but important change to the _convert_messages method in the WrappedAnthropicClient class. It filters out empty messages before processing, which is a good practice to prevent potential issues when interacting with the Anthropic API. The change is straightforward and doesn't introduce any obvious bugs or issues. It's a sensible improvement to the code's robustness.
Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!
spice/wrapped_clients.py
Outdated
| @@ -223,6 +223,7 @@ def _convert_messages( | |||
| ) -> Tuple[str, List[MessageParam]]: | |||
| # Anthropic handles both images and system messages different from OpenAI, only allows alternating user / assistant messages, | |||
| # and doesn't support tools / function calling (still in beta, and doesn't support streaming) | |||
| messages = [m for m in messages if m.get("content", "").strip()] | |||
There was a problem hiding this comment.
Good addition. This line filters out empty messages, which can cause issues with some LLM APIs. It's a proactive approach to prevent potential errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.