add one missing assignment, bump version #93
Conversation
![mentatai[bot]](https://avatars.githubusercontent.com/in/850097?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request includes two changes:
- A version bump in pyproject.toml from 0.3.16 to 0.3.17.
- An improvement to the type hinting in spice.py, adding a generic type parameter to RetryStrategy.
The version bump seems appropriate given the type hinting improvement. The change to the RetryStrategy type hint is a good enhancement for type safety and consistency. Overall, these changes look good and should be ready to merge after confirming the intentionality of the version bump.
Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!
| @@ -12,7 +12,7 @@ packages=["spice"] | |||
|
|
|||
| [project] | |||
| name = "spiceai" | |||
| version = "0.3.16" | |||
| version = "0.3.17" | |||
There was a problem hiding this comment.
Version bump from 0.3.16 to 0.3.17. Make sure this change is intentional and corresponds to the changes made in this PR.
| @@ -390,7 +390,7 @@ async def get_response( | |||
| converter: Callable[[str], T] = string_identity, | |||
| streaming_callback: Optional[Callable[[str], None]] = None, | |||
| retries: int = 0, | |||
| retry_strategy: Optional[RetryStrategy] = None, | |||
| retry_strategy: Optional[RetryStrategy[T]] = None, | |||
There was a problem hiding this comment.
Good addition of the generic type parameter T to RetryStrategy. This improves type safety and makes the code more consistent with the converter parameter.
No description provided.