Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyreadline to pyproject.toml #88

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

jakethekoenig
Copy link
Member

This project is installed from the pyproject.toml which doesn't reference the requirements.txt. We should probably either dynamically import the requirements.txt or delete it and only store the dependencies in the pyproject.toml. I favor deleting the requirements.txt.

@granawkins
Copy link
Member

is that standard? feels like there's always a requirements.txt for a python project?

@jakethekoenig
Copy link
Member Author

is that standard? feels like there's always a requirements.txt for a python project?

Yeah it feels weird to me but I think it is standard when using poetry. I haven't used poetry myself before. Looks like black does it this way. There are ways to dynamically import a requirements.txt into the toml but they look janky and non-standard to me. We certainly don't want the dependencies listed in two places.

@granawkins
Copy link
Member

Ok after we discussed I'm on board with requirements.txt

@jakethekoenig jakethekoenig merged commit f08ac12 into main Feb 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants