support running ragdaemon in non-git directories and adding ignored files to context #8
Conversation
![mentatbot[bot]](https://avatars.githubusercontent.com/in/837875?s=60&v=4){kind=small}
| from ragdaemon.graph import KnowledgeGraph | ||
| from ragdaemon.errors import RagdaemonError | ||
| from ragdaemon.utils import get_document, hash_str, parse_path_ref | ||
| from ragdaemon.utils import get_document, hash_str, parse_path_ref, truncate |
There was a problem hiding this comment.
This function could benefit from a brief docstring explaining its purpose, inputs, and outputs for better code maintainability.
| @@ -100,8 +76,9 @@ def files_checksum(cwd: Path, ignore_patterns: list[str] = []) -> str: | |||
| class Hierarchy(Annotator): | |||
| name = "hierarchy" | |||
|
|
|||
| def __init__(self, *args, ignore_patterns: list[str] = [], **kwargs): | |||
| self.ignore_patterns = ignore_patterns | |||
| def __init__(self, *args, ignore_patterns: set[Path] = set(), **kwargs): | |||
There was a problem hiding this comment.
It's great to see the use of type hints for better code clarity. Consider adding a brief docstring to the __init__ method to explain the purpose of ignore_patterns and its expected format.
| @@ -44,7 +45,15 @@ def __init__(self, graph: KnowledgeGraph, db: Database, verbose: bool = False): | |||
| def _add_path(self, path_str: str): | |||
| """Create a new record in the context for the given path.""" | |||
| if path_str not in self.graph: # e.g. deleted file | |||
| document = "" | |||
| try: | |||
There was a problem hiding this comment.
Consider handling the case where get_document might raise an exception other than FileNotFoundError, ensuring the daemon's robustness.
| @@ -101,13 +101,13 @@ async def update(self, refresh=False): | |||
|
|
|||
| async def watch(self, interval=2, debounce=5): | |||
| """Calls self.update interval debounce seconds after a file is modified.""" | |||
| git_paths = get_non_gitignored_files(self.cwd) | |||
| paths = get_paths_for_directory(self.cwd) | |||
There was a problem hiding this comment.
The watch method's implementation is efficient. However, adding a comment to explain the debounce logic could improve readability.
| return False | ||
|
|
||
|
|
||
| def get_paths_for_directory( |
There was a problem hiding this comment.
This function is well-implemented for fetching directory paths with specific patterns. Adding a docstring would enhance its readability and usability.
| @@ -118,3 +82,17 @@ def get_document(ref: str, cwd: Path, type: str = "file") -> str: | |||
| raise RagdaemonError(f"Invalid type: {type}") | |||
|
|
|||
| return f"{ref}\n{text}" | |||
|
|
|||
|
|
|||
| def truncate(document, model: str, max_tokens: int) -> tuple[str, float]: | |||
There was a problem hiding this comment.
The truncate function is a crucial addition for handling large documents. A docstring explaining its parameters (document, model, max_tokens) and return values would be beneficial.
| from ragdaemon.get_paths import get_paths_for_directory, get_git_root_for_path | ||
|
|
||
|
|
||
| def test_get_paths_for_directory_git(cwd): |
There was a problem hiding this comment.
These tests effectively cover the functionality of get_paths_for_directory. Consider adding a test case for the exclude_patterns parameter to ensure it works as expected.
|
MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. This pull request introduces several key improvements and features, such as supporting non-git directories and handling ignored files in the context. The changes are well-structured, and the new |
No description provided.