Nuke Chroma #49
Nuke Chroma #49
Conversation
![mentatai[bot]](https://avatars.githubusercontent.com/in/850097?s=60&v=4){kind=small}
There was a problem hiding this comment.
The pull request effectively removes dependencies on the ChromaDB and introduces a new PGDB class for handling Postgres databases. However, there are several TODOs and missing error handling that need to be addressed to ensure robustness and functionality. Completing these items will be crucial for maintaining data integrity and handling database interactions effectively.
Butler is in closed beta. Reply with feedback or to ask Butler to review other parts of the PR. Please give feedback with emoji reacts.
ragdaemon/database/__init__.py
Outdated
| # # In case the api key is wrong, try to embed something to trigger an error. | ||
| # _ = db.add(ids="test", documents="test doc") | ||
| # db.delete(ids="test") | ||
| db = PGDB(cwd=cwd, db_path=db_path) |
There was a problem hiding this comment.
It seems like the PGDB class is being used here without handling exceptions specifically for Postgres-related errors. Consider adding specific error handling for Postgres exceptions to provide more detailed feedback about database connection issues or query failures.
ragdaemon/database/pg_database.py
Outdated
| for k, v in metadata.items(): | ||
| if k in self.fields: | ||
| remote_records[id][k] = v | ||
| # TODO: Update remote records |
There was a problem hiding this comment.
The TODO comment here suggests that the implementation for updating remote records is not yet complete. It's important to address this to ensure data consistency between local and remote databases.
ragdaemon/database/pg_database.py
Outdated
| metadatas: list[dict] | dict, | ||
| documents: list[str] | str, | ||
| ) -> list[str]: | ||
| # TODO: Fetch remote records for ids |
There was a problem hiding this comment.
There is another TODO comment indicating that fetching remote records for IDs is not implemented. This needs to be completed to ensure that the add method functions correctly when integrating with a remote Postgres database.
No description provided.