Moar db fixes #45
Moar db fixes #45
Conversation
![mentatai[bot]](https://avatars.githubusercontent.com/in/850097?s=60&v=4){kind=small}
There was a problem hiding this comment.
The updates are coherent with the version bump and cleaning up the 'active' usage across the project. However, ensure that all dependencies and functionalities implicitly relying on the 'active' flag are also addressed to avoid potential issues in production. Overall, the progression to a more simplified and consistent state via these changes seems promising.
Butler is in closed beta. Reply with feedback or to ask Butler to review other parts of the PR. Please give feedback with emoji reacts.
| @@ -7,7 +7,7 @@ packages=["ragdaemon"] | |||
|
|
|||
| [project] | |||
| name = "ragdaemon" | |||
| version = "0.5.2" | |||
| version = "0.5.3" | |||
There was a problem hiding this comment.
The version number in pyproject.toml has been updated correctly from 0.5.2 to 0.5.3. This change is consistent with the version update in ragdaemon/__init__.py.
| @@ -1 +1 @@ | |||
| __version__ = "0.5.2" | |||
| __version__ = "0.5.3" | |||
There was a problem hiding this comment.
The version number has been correctly updated to match the latest release 0.5.3, ensuring consistency across the project configurations.
| @@ -176,7 +176,6 @@ async def annotate( | |||
| "type": "chunk", | |||
| "document": document, | |||
| "checksum": checksum, | |||
| "active": False, | |||
| } | |||
There was a problem hiding this comment.
The removal of the "active" field from node metadata is a significant change. If this field was previously used to filter active records for certain operations or queries, make sure that all functionalities relying on this are updated to work without it.
| "metadatas": [{"active": True} for _ in valid_checksums], | ||
| } | ||
| self._collection.update(**updates) | ||
| # Query | ||
| response = self._collection.query( |
There was a problem hiding this comment.
The change in the query method removes the logic related to handling the active flag, which simplifies querying documents only based on their checksum. This adjustment seems aligned with the removal of the "active" metadata from other parts of the application, but ensure that no functionality dependent on the active status is broken by this update.
| @@ -12,7 +12,6 @@ class NodeMetadata(TypedDict): | |||
| str | |||
| ] # Used to fetch document: path/to/file:start-end, diff_ref:start-end | |||
| checksum: Optional[str] # Unique identifier for chroma; sha256 of the document | |||
| active: bool # Used to filter nodes for search | |||
| chunks: Optional[ | |||
There was a problem hiding this comment.
Removing the active field from the NodeMetadata aligns with your changes across different modules. Just confirm that there are no legacy conditions or functions that check this field to avoid breaks in the graph operations.
No description provided.