-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix circular import #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes made in this pull request efficiently resolve the circular import issue by moving the parse_diff_id
function to utils.py
. This organization prevents dependency conflicts and follows best practices for large projects. All changes consistently reflect the update of the application version to '0.4.7'. Good attention to updating related files consistently, however, ensure to check and test these refactoring changes across the module where these methods might be used.
Butler is in closed beta. Reply with feedback or to ask Butler to review other parts of the PR. Please give feedback with emoji reacts.
@@ -1 +1 @@ | |||
__version__ = "0.4.6" | |||
__version__ = "0.4.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure the version update here matches with the version updates across all relevant files. Currently, the version is updated consistently in pyproject.toml
and here which is great practice for maintaining consistency.
@@ -7,7 +7,13 @@ | |||
from ragdaemon.get_paths import get_git_root_for_path | |||
from ragdaemon.graph import KnowledgeGraph | |||
from ragdaemon.errors import RagdaemonError | |||
from ragdaemon.utils import get_document, hash_str, parse_path_ref, truncate | |||
from ragdaemon.utils import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring to move parse_diff_id
from diff.py
to utils.py
to resolve circular imports is a good approach. It's essential to ensure that all files that used the old import are updated accordingly.
name = "ragdaemon" | ||
version = "0.4.6" | ||
version = "0.4.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "ragdaemon" | |
version = "0.4.6" | |
version = "0.4.7" | |
version = "0.4.7" |
It's good to update the project version to reflect new changes or fixes such as the fix for the circular dependency issue.
No description provided.