Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event bug fix #83

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

AndrewJanong
Copy link

No description provided.

There was a problem on the add event and delete event commands, where they don't work when there is no end time. This is because one of the functions used does not allow null values.

To solve this, inside the function was made so that the end time would be equal to the start time when it is null.
@AndrewJanong AndrewJanong added the priority.High Must do label Nov 2, 2023
@AndrewJanong AndrewJanong added this to the v1.3 milestone Nov 2, 2023
@AndrewJanong AndrewJanong requested a review from a team November 2, 2023 18:42
@AndrewJanong AndrewJanong self-assigned this Nov 2, 2023
@AndrewJanong AndrewJanong linked an issue Nov 2, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #83 (5e36db0) into master (55f7587) will decrease coverage by 1.35%.
Report is 19 commits behind head on master.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
- Coverage     74.04%   72.69%   -1.35%     
- Complexity      712      713       +1     
============================================
  Files           111      113       +2     
  Lines          2281     2326      +45     
  Branches        266      272       +6     
============================================
+ Hits           1689     1691       +2     
- Misses          497      535      +38     
- Partials         95      100       +5     
Files Coverage Δ
...ava/seedu/address/model/event/UniqueEventList.java 36.36% <0.00%> (-3.64%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@Nixx162 Nixx162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nixx162 Nixx162 merged commit 0abcaa5 into AY2324S1-CS2103T-W16-1:master Nov 2, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event bug fix
2 participants