Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag-related features #63

Merged
merged 16 commits into from
Nov 1, 2023
Merged

Conversation

zekone
Copy link

@zekone zekone commented Oct 27, 2023

Features added:

  • Add tags to a contact
    eg. add tag -id 1 -t frontend -t java
  • Delete tags from a contact
    eg. delete tag -id 1 -t frontend -t java

Documentation update:

  • UG: Added guides for the two newly added features above.
  • UG: Added notes about ... for items that can be used multiple time such as -t.
  • DG: Updated use cases for add and delete tag.

Others:

  • Added tests for the new features.

@zekone zekone added this to the v1.3 milestone Oct 27, 2023
@zekone zekone added the priority.High Must do label Oct 27, 2023
@zekone zekone self-assigned this Oct 27, 2023
@zekone zekone linked an issue Oct 27, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #63 (36e01b7) into master (05c2290) will decrease coverage by 2.94%.
Report is 9 commits behind head on master.
The diff coverage is 63.93%.

@@             Coverage Diff              @@
##             master      #63      +/-   ##
============================================
- Coverage     77.75%   74.82%   -2.94%     
- Complexity      627      702      +75     
============================================
  Files           103      112       +9     
  Lines          1951     2232     +281     
  Branches        200      257      +57     
============================================
+ Hits           1517     1670     +153     
- Misses          377      468      +91     
- Partials         57       94      +37     
Files Coverage Δ
...in/java/seedu/address/commons/util/StringUtil.java 95.65% <100.00%> (+0.91%) ⬆️
src/main/java/seedu/address/logic/Messages.java 68.57% <ø> (ø)
...seedu/address/logic/commands/AddPersonCommand.java 100.00% <ø> (ø)
...edu/address/logic/commands/DeleteEventCommand.java 100.00% <100.00%> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 77.77% <100.00%> (+2.77%) ⬆️
...ain/java/seedu/address/logic/parser/CliSyntax.java 94.44% <100.00%> (+0.32%) ⬆️
...eedu/address/logic/parser/DeleteCommandParser.java 77.77% <100.00%> (+2.77%) ⬆️
.../seedu/address/logic/parser/HelpCommandParser.java 100.00% <ø> (ø)
.../seedu/address/logic/parser/ListCommandParser.java 75.00% <100.00%> (ø)
src/main/java/seedu/address/model/AddressBook.java 61.66% <100.00%> (-5.00%) ⬇️
... and 22 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@Nixx162 Nixx162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewJanong AndrewJanong merged commit 2910839 into AY2324S1-CS2103T-W16-1:master Nov 1, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tag-related features
3 participants