Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note and delete note feature #39

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

josepholim
Copy link

  • Implemented features for adding note and deleting note, with the test cases.
  • Adapt the User Guide for notes to add and delete note by id.

@josepholim josepholim added the priority.High Must do label Oct 15, 2023
@josepholim josepholim added this to the v1.2 milestone Oct 15, 2023
@josepholim josepholim self-assigned this Oct 15, 2023
@josepholim josepholim linked an issue Oct 15, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #39 (4abc955) into master (0c0fde5) will decrease coverage by 0.38%.
The diff coverage is 54.45%.

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
- Coverage     74.79%   74.42%   -0.38%     
- Complexity      492      516      +24     
============================================
  Files            91       97       +6     
  Lines          1615     1701      +86     
  Branches        155      163       +8     
============================================
+ Hits           1208     1266      +58     
- Misses          360      384      +24     
- Partials         47       51       +4     
Files Coverage Δ
...a/seedu/address/logic/commands/AddNoteCommand.java 100.00% <100.00%> (ø)
...eedu/address/logic/commands/DeleteNoteCommand.java 100.00% <100.00%> (ø)
...ain/java/seedu/address/logic/parser/CliSyntax.java 93.75% <100.00%> (+1.44%) ⬆️
...ain/java/seedu/address/model/note/NoteContent.java 100.00% <100.00%> (ø)
.../main/java/seedu/address/model/note/NoteTitle.java 100.00% <100.00%> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 75.00% <0.00%> (-25.00%) ⬇️
...eedu/address/logic/parser/DeleteCommandParser.java 75.00% <0.00%> (-25.00%) ⬇️
...c/main/java/seedu/address/model/person/Person.java 94.64% <90.90%> (-1.28%) ⬇️
.../java/seedu/address/model/util/SampleDataUtil.java 13.04% <0.00%> (ø)
...in/java/seedu/address/storage/JsonAdaptedNote.java 69.23% <80.00%> (+69.23%) ⬆️
... and 4 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@AndrewJanong AndrewJanong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just add more test cases later.

@AndrewJanong AndrewJanong merged commit 404bc61 into AY2324S1-CS2103T-W16-1:master Oct 16, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notes feature
2 participants