Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete tag feature #154

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

zekone
Copy link

@zekone zekone commented Nov 9, 2023

Previously, non existent tags in a contact were accepted in the delete tag command and showed a success message. This behavior has been changed to notifying the user if the tags are non existent. The command will still be executed as usual, with no errors thrown.

tag fix

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #154 (79113cd) into master (9cedc7b) will increase coverage by 0.03%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master     #154      +/-   ##
============================================
+ Coverage     71.92%   71.96%   +0.03%     
- Complexity      685      686       +1     
============================================
  Files           111      111              
  Lines          2212     2222      +10     
  Branches        250      252       +2     
============================================
+ Hits           1591     1599       +8     
- Misses          528      529       +1     
- Partials         93       94       +1     
Files Coverage Δ
...seedu/address/logic/commands/DeleteTagCommand.java 78.94% <83.33%> (+0.37%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

@Nixx162 Nixx162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nixx162 Nixx162 merged commit 927d1b9 into AY2324S1-CS2103T-W16-1:master Nov 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants