Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ListCommand class functionality #39

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Update ListCommand class functionality #39

merged 3 commits into from
Oct 17, 2023

Conversation

wamps-jp
Copy link

No description provided.

@wamps-jp wamps-jp added the priority.High Must do tasks (CS2103T label) label Oct 17, 2023
@wamps-jp wamps-jp added this to the v1.2 milestone Oct 17, 2023
@wamps-jp wamps-jp added the type.Enhancement Enhancement to an existing feature or user story (CS2103T label) label Oct 17, 2023
@wamps-jp wamps-jp linked an issue Oct 17, 2023 that may be closed by this pull request
As a user, I can view my contacts #14
Closed
3 tasks
@CJ-Lee01 CJ-Lee01 requested review from a team, wxwern and tanshiyu1999 and removed request for a team October 17, 2023 14:00
CJ-Lee01
CJ-Lee01 approved these changes Oct 17, 2023
View reviewed changes
Copy link

@CJ-Lee01 CJ-Lee01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/main/java/seedu/address/logic/commands/ListCommand.java Show resolved Hide resolved
src/main/java/seedu/address/model/Model.java Show resolved Hide resolved
wxwern
wxwern approved these changes Oct 17, 2023
View reviewed changes
Copy link

@wxwern wxwern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks alright to me

src/main/java/seedu/address/model/Model.java Outdated Show resolved Hide resolved
@wamps-jp wamps-jp removed the request for review from tanshiyu1999 October 17, 2023 15:09
CJ-Lee01
CJ-Lee01 approved these changes Oct 17, 2023
View reviewed changes
Copy link

@CJ-Lee01 CJ-Lee01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wamps-jp wamps-jp merged commit f1515f8 into AY2324S1-CS2103T-W08-3:master Oct 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJ-Lee01 CJ-Lee01 CJ-Lee01 approved these changes

@wxwern wxwern wxwern approved these changes

Assignees
No one assigned
Labels
priority.High Must do tasks (CS2103T label) type.Enhancement Enhancement to an existing feature or user story (CS2103T label)
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

As a user, I can view my contacts
3 participants
@wamps-jp @wxwern @CJ-Lee01