-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update delete contact functionality #32
Update delete contact functionality #32
Conversation
src/main/java/seedu/address/logic/parser/DeleteCommandParser.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay. I think the usage of Object selector
might be a bit questionable (as in it might create complications later) but for now it's fine. Just noting that for future edits, if ever.
I agree that the selector being of type I wanted the selector to have either type I wonder if there is a way to strictly enforce that the selector is only used for the equals method, was thinking if I should wrap it in |
closes #13