Refactor the "Prefix" class to "Flag", and update the defaults to match the Unix-like syntax "--flag" #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done in preparation for the syntax change for a flag, formerly prefix, from f/ to --f, to make it in line with common CLI naming. Additionally, future functionality includes prefix-matching of a flag, which will have naming conflicts and confusions if this is not renamed.
wxwern
added
the
type.Chore
wxwern
requested review from
a team,
tanshiyu1999 and
wamps-jp
and removed request for
a team
A future update will allow for prefix-only matching separately. For now, this is done to reduce ambiguity and allow for more flags to be defined with no conflicts.
wxwern
changed the title
McNaBry
reviewed
Oct 10, 2023
Yeah, I missed a few and have fixed them in the latest commit. Note that |
McNaBry
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The renaming is primarily done because it may conflict with future prefix-matching functionality planned. This also makes the class use a common name for easier understanding (it is commonly called a command-line option, flag, or switch).
The refactor also includes some improvements in internal structure to allow for flexible syntax changes.
The update of the syntax (e.g., from
n/) to the Unix-like variant (e.g., to--name) closes #16.Note: The existing code does not require a whitespace between flags though, which may be confusing since something like
--nameAlicecould be accepted. This will be addressed in a separate PR to revamp the argument parsing.