Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UG #202

Merged
merged 11 commits into from
Nov 13, 2023
Merged

Refactor UG #202

merged 11 commits into from
Nov 13, 2023

Conversation

McNaBry
Copy link

@McNaBry McNaBry commented Nov 13, 2023

A final attempt at fixing the UG and DG. A testament to our great efforts.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #202 (8804cb6) into master (0e8a46c) will not change coverage.
The diff coverage is n/a.

❗ Current head 8804cb6 differs from pull request most recent head 2365fb5. Consider uploading reports for the commit 2365fb5 to get more accurate results

@@            Coverage Diff            @@
##             master     #202   +/-   ##
=========================================
  Coverage     83.22%   83.22%           
  Complexity      992      992           
=========================================
  Files            95       95           
  Lines          2945     2945           
  Branches        429      429           
=========================================
  Hits           2451     2451           
  Misses          327      327           
  Partials        167      167           

@McNaBry McNaBry requested review from wxwern, tanshiyu1999, wamps-jp, CJ-Lee01 and a team November 13, 2023 18:49
@wamps-jp wamps-jp removed the request for review from a team November 13, 2023 18:49
@wamps-jp
Copy link

LGTM

@McNaBry McNaBry added this to the v1.4 milestone Nov 13, 2023
@McNaBry McNaBry added type.Documentation Items related to or requiring documentation (custom label) priority.High Must do tasks (CS2103T label) labels Nov 13, 2023
@McNaBry McNaBry enabled auto-merge November 13, 2023 18:50
@McNaBry McNaBry disabled auto-merge November 13, 2023 18:52
@McNaBry McNaBry merged commit bc8e2f3 into AY2324S1-CS2103T-W08-3:master Nov 13, 2023
3 checks passed
Copy link

@wamps-jp wamps-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do tasks (CS2103T label) type.Documentation Items related to or requiring documentation (custom label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants