allow wildcard files to have comment lines #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows very simple comments in Wildcards files: if lines start with "#", they are a comment.
Having comments allows wildcard files shared between people to contain authorship information, sources, and other information.
Beyond wanting this on general principle, I personally want it for compatibility:
I'll be releasing my extended wildcards extension at some point, and it will include a number of built-in public domain wildcard lists. Because my library supports comments, I have information in them like:
However, I intentionally don't use any other features not found in this Wildcards library other than these comments, so this small change will make those files compatible.