Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show Rubocop not loaded warning #89

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Oct 30, 2023

This error is shown at runtime to users using foreman-rake. Prior to 9d9a835 it was only attempting to load RuboCop when invoking the task.

Fixes: 9d9a835 ("Add separate jenkins-test jobs")

This error is shown at runtime to users using foreman-rake. Prior to
9d9a835 it was only attempting to load
RuboCop when invoking the task.

Fixes: 9d9a835 ("Add separate jenkins-test jobs")
@ekohl
Copy link
Contributor Author

ekohl commented Oct 30, 2023

Copy link
Member

@m-bucher m-bucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware that everyone's favorite Cop (now) allows comments 😅

Test-failures are not related and build-test seems to be broken at the moment.

@m-bucher m-bucher merged commit 90aa47a into ATIX-AG:master Oct 30, 2023
2 of 5 checks passed
@ekohl ekohl deleted the hide-rubocop-warning-at-runtime branch October 30, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants