Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 3.0.1 #100

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Bump version to 3.0.1 #100

merged 1 commit into from
Apr 15, 2024

Conversation

dosas
Copy link
Contributor

@dosas dosas commented Apr 10, 2024

Someone with permissions should also add the tag for this commit please.

@dosas dosas requested a review from m-bucher April 10, 2024 13:46
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks reasonable to me. I wonder why foreman_acd only required a single change for the last version bump?

@dosas
Copy link
Contributor Author

dosas commented Apr 10, 2024

Probably because it was forgotten since the first version bump https://github.com/ATIX-AG/foreman_acd/blob/master/package.json#L3

@maximiliankolb
Copy link
Contributor

Argh! 🙈
Would you please create another PR to fix this? @dosas

Also, this needs at least some basic docs internally. Or maybe upstream packaging reports a version mismatch and therefore fails?

@dosas
Copy link
Contributor Author

dosas commented Apr 11, 2024

Argh! 🙈 Would you please create another PR to fix this? @dosas

Also, this needs at least some basic docs internally. Or maybe upstream packaging reports a version mismatch and therefore fails?

I am not sure if the version in js is relevant since foreman community plugins do not bump it either or rather randomly:

Copy link
Contributor

@nadjaheitmann nadjaheitmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the version in package.json file is not kept up to date, either. However, if you want to do a version bump, you usually do a version bump in the lib/plugin_name/version.rb file, only.

@dosas dosas force-pushed the feature/bump-version branch from 9a3cbfd to ba13102 Compare April 11, 2024 08:05
@dosas dosas requested a review from nadjaheitmann April 11, 2024 08:09
package.json Outdated Show resolved Hide resolved
@dosas dosas changed the title Bump version to 3.1.0 Bump version to 3.0.1 Apr 15, 2024
@dosas dosas force-pushed the feature/bump-version branch from ba13102 to 0eed16b Compare April 15, 2024 12:09
@dosas
Copy link
Contributor Author

dosas commented Apr 15, 2024

@nadjaheitmann Once this PR is merged, do you have the permissions to set the correct tag?

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@nadjaheitmann
Copy link
Contributor

@nadjaheitmann Once this PR is merged, do you have the permissions to set the correct tag?

I think so. Let's give it a try ;)

@nadjaheitmann nadjaheitmann merged commit 25c0740 into master Apr 15, 2024
32 of 38 checks passed
@nadjaheitmann nadjaheitmann deleted the feature/bump-version branch April 15, 2024 12:42
@nadjaheitmann
Copy link
Contributor

I have created a tag v3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants