-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 3.0.1 #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff looks reasonable to me. I wonder why foreman_acd only required a single change for the last version bump?
Probably because it was forgotten since the first version bump https://github.com/ATIX-AG/foreman_acd/blob/master/package.json#L3 |
Argh! 🙈 Also, this needs at least some basic docs internally. Or maybe upstream packaging reports a version mismatch and therefore fails? |
I am not sure if the version in js is relevant since foreman community plugins do not bump it either or rather randomly: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the version in package.json file is not kept up to date, either. However, if you want to do a version bump, you usually do a version bump in the lib/plugin_name/version.rb
file, only.
9a3cbfd
to
ba13102
Compare
ba13102
to
0eed16b
Compare
@nadjaheitmann Once this PR is merged, do you have the permissions to set the correct tag? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
I think so. Let's give it a try ;) |
I have created a tag v3.0.1 |
Someone with permissions should also add the tag for this commit please.