Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only list rubocop as dependency once #94

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Only list rubocop as dependency once #94

merged 1 commit into from
Dec 11, 2024

Conversation

dosas
Copy link
Contributor

@dosas dosas commented Dec 10, 2024

No description provided.

@dosas dosas requested a review from bastian-src December 10, 2024 15:47
maximiliankolb
maximiliankolb approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and similar to foreman_scc_manager.

@bastian-src
Copy link
Contributor

LGTM, thanks @maximiliankolb @dosas!

@bastian-src bastian-src merged commit 0555558 into main Dec 11, 2024
21 checks passed
@bastian-src bastian-src deleted the fix-rubocop-dependency branch December 11, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb approved these changes

@bastian-src bastian-src Awaiting requested review from bastian-src

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dosas @bastian-src @maximiliankolb