Switch to async foreman-tasks-based utilization trigger #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastian-src
force-pushed
the
feature/add_utilization_job
branch
19 times, most recently
from
f4b0dd9 to
a20dac2
Compare
* foreman-tasks >= 10.0, < 11 * theforeman-rubocop ~> 0.1.0
Add task RefreshResourceQuotaUtilization which calls determine_utilization on every ResourceQuota. The command iterates all hosts of a ResourceQuota and sets the host.host_resources which is used for the ResourceQuota.utilization. This guarantees that Foreman does not miss changes to HostResources, when they are not performed via the Foreman UI. Moreover, it increases performance since Foreman Resource Quota does not re-compute a ResourceQuota's utilization on host deployment and, instead, takes the last-computed sum of HostResources. However, this comes with the downside that HostResources might be missed when edited out-of Foreman UI and new hosts are deployed before the task is executed.
A Hosts's HostResources are determined during the validation step but not saved, because the Host must exist before its HostResources can be stored (not-null database constraint). We add a routine which saves the HostResources immediately after a Host is saved in case its Host.host_resources changed
bastian-src
force-pushed
the
feature/add_utilization_job
branch
from
a20dac2 to
3d09d93
Compare
5 tasks
Thorben-D
approved these changes
Nov 27, 2024
|
The failing packit job is caused by a missing foreman-tasks dependency on the foreman-packaging:rubygem-foreman_resource_quota.spec file. Adding this with a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of re-calculating the resource quota utilization on every host-deployment, use the last utilization and re-calculate it every day with a foreman-tasks Recurring Logic
Is part of #11