Fix resource quota permissions #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastian-src
force-pushed
the
fix/resource_quota_permission_names
branch
from
40129c9 to
c56e3a3
Compare
* Switch from string to symbol * Remove prefix in permission names * Set explicit resource_quotas permission name in model
bastian-src
force-pushed
the
fix/resource_quota_permission_names
branch
from
c56e3a3 to
4ac337d
Compare
nadjaheitmann
approved these changes
Nov 25, 2024
bastian-src
force-pushed
the
fix/resource_quota_permission_names
branch
2 times, most recently
from
a914dc9 to
cd71c23
Compare
|
I've created #76 as a follow-up to run foreman permission tests automatically. |
| @@ -0,0 +1,18 @@ | |||
| require 'test_plugin_helper' | |||
| require 'foreman_tasks/test_helpers' | |||
There was a problem hiding this comment.
I guess you should fix rubocop ;)
How is the test related to the permission fix?
There was a problem hiding this comment.
I'd have an issue with GitHub (might've been my fault) - the commit was unrelated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from string to symbol and remove prefix