Remove react-dom/server dependency #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactDOMServer has been used to compare React components. Such comparison is not necessary and therefore, the dependency can be removed.
bastian-src
force-pushed
the
fix/remove_react_dom_server_dependency
branch
from
cc40e85 to
fd8cf4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactDOMServer has been used to compare React components. Such comparison is not necessary and therefore, the dependency can be removed.
When placing the
updateResourceUtilizationView()-call right in the component, it might be called several times due to re-rendering. In order to mitigate re-setting issues, it was important that theupdateResourceUtilizationViewfunction sets the corresponding values (setResourceUtilizationPercentandsetResourceUtilizationTooltipText) only once/when they actually change.To recognize such change, the helper-function
areReactElementsEqualwas implemented which compares React components. This adds a dependency toreact-dom/server.The comparison helper-function, and therefore the dependency, can be removed by moving
updateResourceUtilizationView()in auseEffect()that is called only once (see here).