Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theforeman github actions for JS tests #31

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

bastian-src
Copy link
Contributor

@bastian-src bastian-src commented Mar 27, 2024

Change GitHub actions for JS tests to foreman github actions.

  • Fix existing tests of webpack/lib Katello component EditableTextInput
  • Add preliminary test for StatusPropertiesLabel

Additionaly:

  • Adapt jest.config.js for JS test suite
  • Upgrade @testing-library/react to 14.2.2

@bastian-src bastian-src marked this pull request as draft March 27, 2024 19:50
@bastian-src bastian-src force-pushed the feature/add_foreman_github_actions_js branch 2 times, most recently from 483d16d to fb63511 Compare March 27, 2024 19:59
@bastian-src bastian-src force-pushed the feature/add_foreman_github_actions_js branch from fb63511 to 72165a7 Compare March 27, 2024 20:28
@bastian-src bastian-src marked this pull request as ready for review March 27, 2024 20:28
@bastian-src bastian-src requested a review from dosas March 27, 2024 20:33
Copy link
Contributor

@dosas dosas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@bastian-src bastian-src force-pushed the feature/add_foreman_github_actions_js branch from 72165a7 to 920ba90 Compare April 2, 2024 06:43
* Fix tests for lib/EditableTextInput component
* Add preliminary tests for StatusPropertiesLabel
@bastian-src bastian-src force-pushed the feature/add_foreman_github_actions_js branch from 920ba90 to e50db8a Compare April 2, 2024 07:08
@bastian-src
Copy link
Contributor Author

Node 14 errors are unrelated (see foreman_ansible), merging.

@bastian-src bastian-src merged commit b908290 into main Apr 2, 2024
16 of 21 checks passed
@quba42 quba42 deleted the feature/add_foreman_github_actions_js branch April 2, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants