Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint 12.2.3 issues and drop react-intl #14

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

bastian-src
Copy link
Contributor

  • Fix JS iteration suggested by eslint
  • Drop react-intl dependency as it is included in @theforeman/foreman-vendor

@bastian-src
Copy link
Contributor Author

@dosas When removing react-intl, I probably have to publish a new package-lock.json, right?

Or does dependabot take care of this too?

@dosas
Copy link
Contributor

dosas commented Jan 15, 2024

@bastian-src AFAIK running npm uninstall react-intl (which I would favor over editing package.json) should adapt package.json and package-lock.json. Which can then be commited and pushed.
Dependabot does not take care of this.

* Incorporate eslint for .. in iteration
* Drop react-intl as it is included in @theforeman/vendor
@bastian-src bastian-src force-pushed the fix/dependabot-eslint-12.2.3 branch from dcb634c to aa4ba1a Compare January 23, 2024 09:52
@bastian-src bastian-src self-assigned this Jan 23, 2024
@bastian-src bastian-src requested a review from dosas January 23, 2024 10:12
@bastian-src bastian-src marked this pull request as ready for review January 23, 2024 10:12
@bastian-src bastian-src merged commit 1f08f20 into main Jan 23, 2024
4 checks passed
@maximiliankolb maximiliankolb deleted the fix/dependabot-eslint-12.2.3 branch January 29, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants