Merge pull request #2449 from ASFHyP3/update-multi-burst-todos

remove multi-burst TODOs
ASFHyP3 · Oct 3, 2024 · a4ff4a5 · a4ff4a5
2 parents c5fc0a7 + b702444
commit a4ff4a5
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 12 deletions.
diff --git a/apps/api/src/hyp3_api/validation.py b/apps/api/src/hyp3_api/validation.py
@@ -136,7 +136,6 @@ def get_multipolygon_from_geojson(input_file):
     return MultiPolygon(polygons)
 
 
-# TODO https://github.com/ASFHyP3/hyp3/issues/2442 remove this function after two burst types are merged
 def convert_single_burst_jobs(jobs: list[dict]) -> list[dict]:
     jobs = deepcopy(jobs)
     for job in jobs:

diff --git a/apps/set-batch-overrides/src/set_batch_overrides.py b/apps/set-batch-overrides/src/set_batch_overrides.py
@@ -65,7 +65,6 @@ def get_insar_isce_burst_memory(job_parameters: dict) -> str:
 def lambda_handler(event: dict, _) -> dict:
     job_type, job_parameters = event['job_type'], event['job_parameters']
 
-    # TODO https://github.com/ASFHyP3/hyp3/issues/2442 rename to INSAR_ISCE_BURST after the two burst types are merged
     if job_type == 'INSAR_ISCE_MULTI_BURST':
         memory = get_insar_isce_burst_memory(job_parameters)
         omp_num_threads = INSAR_ISCE_BURST_OMP_NUM_THREADS[memory]

diff --git a/tests/test_api/test_validation.py b/tests/test_api/test_validation.py
@@ -424,17 +424,13 @@ def test_validate_jobs():
             'job_parameters': {}
         },
         {
-            # TODO https://github.com/ASFHyP3/hyp3/issues/2442
-            #  rename to INSAR_ISCE_BURST after the two burst types are merged
             'job_type': 'INSAR_ISCE_MULTI_BURST',
             'job_parameters': {
                 'reference': [valid_burst_pair[0]],
                 'secondary': [valid_burst_pair[1]]
             }
         },
         {
-            # TODO https://github.com/ASFHyP3/hyp3/issues/2442
-            #  remove this test case after the two burst types are merged
             'job_type': 'INSAR_ISCE_BURST',
             'job_parameters': {
                 'granules': [valid_burst_pair[0], valid_burst_pair[1]]
@@ -467,8 +463,6 @@ def test_validate_jobs():
 
     jobs = [
         {
-            # TODO https://github.com/ASFHyP3/hyp3/issues/2442
-            #  rename to INSAR_ISCE_BURST after the two burst types are merged
             'job_type': 'INSAR_ISCE_MULTI_BURST',
             'job_parameters': {
                 'reference': [invalid_burst_pair[0]],
@@ -479,8 +473,6 @@ def test_validate_jobs():
     with raises(validation.GranuleValidationError):
         validation.validate_jobs(jobs)
 
-    # TODO https://github.com/ASFHyP3/hyp3/issues/2442
-    #  remove this test case after the two burst types are merged
     jobs = [
         {
             'job_type': 'INSAR_ISCE_BURST',

diff --git a/tests/test_set_batch_overrides.py b/tests/test_set_batch_overrides.py
@@ -16,8 +16,6 @@
 
 def mock_insar_isce_burst_job(looks: str, bursts: int) -> dict:
     return {
-        # TODO https://github.com/ASFHyP3/hyp3/issues/2442
-        #  rename to INSAR_ISCE_BURST after the two burst types are merged
         'job_type': 'INSAR_ISCE_MULTI_BURST',
         'job_parameters': {
             'looks': looks,