-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ACLE macros for FEAT_PAuth_LR #292
Conversation
The Armv9.5a introduces the FEAT_PAuth_LR extension, adding an enhancement to the Pointer Authentication extension where the value of PC is used as a diversifier when signing pointers. This updates the ACLE to support the extension by the introduction of a new feature marcro and the addition of a new possible value to the existing `__ARM_FEATURE_PAC_DEFAULT` macro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to my inline comments, there's a typo in the commit message: "marcro"
Thank's @vhscampos ! I've fixed the items from the comments and the typo in the PR description. I'll make sure it's also fixed on the commit message when the change is merged. |
LGTM. Thank you! |
@all-contributors please add @pratlucas for code |
I've put up a pull request to add @pratlucas! 🎉 |
This updates clang's target defines to include the ACLE changes covering the FEAT_PAuth_LR architecture extension. The changes include: * The new `__ARM_FEATURE_PAUTH_LR` feature macro, which is set to 1 when FEAT_PAuth_LR is available in the target. * A new bit field for the existing `__ARM_FEATURE_PAC_DEFAULT` macro, indicating the use of PC as a diversifier for Pointer Authentication (from -mbranch-protection=pac-ret+pc). The approved changes to the ACLE spec can be found here: ARM-software/acle#292
This updates clang's target defines to include the ACLE changes covering the FEAT_PAuth_LR architecture extension. The changes include: * The new `__ARM_FEATURE_PAUTH_LR` feature macro, which is set to 1 when FEAT_PAuth_LR is available in the target. * A new bit field for the existing `__ARM_FEATURE_PAC_DEFAULT` macro, indicating the use of PC as a diversifier for Pointer Authentication (from -mbranch-protection=pac-ret+pc). The approved changes to the ACLE spec can be found here: ARM-software/acle#292
This updates clang's target defines to include the ACLE changes covering the FEAT_PAuth_LR architecture extension. The changes include: * The new `__ARM_FEATURE_PAUTH_LR` feature macro, which is set to 1 when FEAT_PAuth_LR is available in the target. * A new bit field for the existing `__ARM_FEATURE_PAC_DEFAULT` macro, indicating the use of PC as a diversifier for Pointer Authentication (from -mbranch-protection=pac-ret+pc). The approved changes to the ACLE spec can be found here: ARM-software/acle#292
This updates clang's target defines to include the ACLE changes covering the FEAT_PAuth_LR architecture extension. The changes include: * The new `__ARM_FEATURE_PAUTH_LR` feature macro, which is set to 1 when FEAT_PAuth_LR is available in the target. * A new bit field for the existing `__ARM_FEATURE_PAC_DEFAULT` macro, indicating the use of PC as a diversifier for Pointer Authentication (from -mbranch-protection=pac-ret+pc). The approved changes to the ACLE spec can be found here: ARM-software/acle#292
* Add ACLE macros for FEAT_PAuth_LR The Armv9.5a introduces the FEAT_PAuth_LR extension, adding an enhancement to the Pointer Authentication extension where the value of PC is used as a diversifier when signing pointers. This updates the ACLE to support the extension by the introduction of a new feature macro and the addition of a new possible value to the existing `__ARM_FEATURE_PAC_DEFAULT` macro.
@@ -362,6 +362,11 @@ Armv8.4-A [[ARMARMv84]](#ARMARMv84). Support is added for the Dot Product intrin | |||
* Added description of SVE reinterpret intrinsics. | |||
* Changes for [Function Multi Versioning](#function-multi-versioning): | |||
* Added [MOPS](#memcpy-family-of-operations-intrinsics---mops). | |||
* Introduced the `__ARM_FEATURE_PAUTH_LR` feature macro in section | |||
[Pointer Authentication](#pointer-authentication) to indicate target support | |||
for the Armv9.5-A's PAC Enhancements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Armv9.5-A's PAC
Remove the possessive apostrophe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor change
The Armv9.5a introduces the FEAT_PAuth_LR extension, adding an enhancement
to the Pointer Authentication extension where the value of PC is used as
a diversifier when signing pointers.
This updates the ACLE to support the extension by the introduction of a
new feature macro and the addition of a new possible value to the
existing
__ARM_FEATURE_PAC_DEFAULT
macro.