Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACLE macros for FEAT_PAuth_LR #292

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

pratlucas
Copy link
Contributor

@pratlucas pratlucas commented Jan 24, 2024

The Armv9.5a introduces the FEAT_PAuth_LR extension, adding an enhancement
to the Pointer Authentication extension where the value of PC is used as
a diversifier when signing pointers.

This updates the ACLE to support the extension by the introduction of a
new feature macro and the addition of a new possible value to the
existing __ARM_FEATURE_PAC_DEFAULT macro.

The Armv9.5a introduces the FEAT_PAuth_LR extension, adding an enhancement
to the Pointer Authentication extension where the value of PC is used as
a diversifier when signing pointers.

This updates the ACLE to support the extension by the introduction of a
new feature marcro and the addition of a new possible value to the
existing `__ARM_FEATURE_PAC_DEFAULT` macro.
Copy link
Member

@vhscampos vhscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my inline comments, there's a typo in the commit message: "marcro"

main/acle.md Outdated Show resolved Hide resolved
main/acle.md Outdated Show resolved Hide resolved
main/acle.md Outdated Show resolved Hide resolved
@pratlucas
Copy link
Contributor Author

Thank's @vhscampos ! I've fixed the items from the comments and the typo in the PR description. I'll make sure it's also fixed on the commit message when the change is merged.

@vhscampos
Copy link
Member

LGTM. Thank you!

@vhscampos vhscampos merged commit 54f0897 into ARM-software:main Jan 29, 2024
4 checks passed
@vhscampos
Copy link
Member

@all-contributors please add @pratlucas for code

Copy link
Contributor

@vhscampos

I've put up a pull request to add @pratlucas! 🎉

pratlucas added a commit to pratlucas/llvm-project that referenced this pull request Jan 31, 2024
This updates clang's target defines to include the ACLE changes covering
the FEAT_PAuth_LR architecture extension.
The changes include:
* The new `__ARM_FEATURE_PAUTH_LR` feature macro, which is set to 1 when
  FEAT_PAuth_LR is available in the target.
* A new bit field for the existing `__ARM_FEATURE_PAC_DEFAULT` macro,
  indicating the use of PC as a diversifier for Pointer Authentication
  (from -mbranch-protection=pac-ret+pc).

The approved changes to the ACLE spec can be found here:
ARM-software/acle#292
pratlucas added a commit to llvm/llvm-project that referenced this pull request Feb 1, 2024
This updates clang's target defines to include the ACLE changes covering
the FEAT_PAuth_LR architecture extension.
The changes include:
* The new `__ARM_FEATURE_PAUTH_LR` feature macro, which is set to 1 when
  FEAT_PAuth_LR is available in the target.
* A new bit field for the existing `__ARM_FEATURE_PAC_DEFAULT` macro,
  indicating the use of PC as a diversifier for Pointer Authentication
  (from -mbranch-protection=pac-ret+pc).

The approved changes to the ACLE spec can be found here:
ARM-software/acle#292
carlosgalvezp pushed a commit to carlosgalvezp/llvm-project that referenced this pull request Feb 1, 2024
This updates clang's target defines to include the ACLE changes covering
the FEAT_PAuth_LR architecture extension.
The changes include:
* The new `__ARM_FEATURE_PAUTH_LR` feature macro, which is set to 1 when
  FEAT_PAuth_LR is available in the target.
* A new bit field for the existing `__ARM_FEATURE_PAC_DEFAULT` macro,
  indicating the use of PC as a diversifier for Pointer Authentication
  (from -mbranch-protection=pac-ret+pc).

The approved changes to the ACLE spec can be found here:
ARM-software/acle#292
agozillon pushed a commit to agozillon/llvm-project that referenced this pull request Feb 5, 2024
This updates clang's target defines to include the ACLE changes covering
the FEAT_PAuth_LR architecture extension.
The changes include:
* The new `__ARM_FEATURE_PAUTH_LR` feature macro, which is set to 1 when
  FEAT_PAuth_LR is available in the target.
* A new bit field for the existing `__ARM_FEATURE_PAC_DEFAULT` macro,
  indicating the use of PC as a diversifier for Pointer Authentication
  (from -mbranch-protection=pac-ret+pc).

The approved changes to the ACLE spec can be found here:
ARM-software/acle#292
hassnaaHamdi pushed a commit to hassnaaHamdi/ACLE that referenced this pull request Mar 11, 2024
* Add ACLE macros for FEAT_PAuth_LR

The Armv9.5a introduces the FEAT_PAuth_LR extension, adding an enhancement
to the Pointer Authentication extension where the value of PC is used as
a diversifier when signing pointers.

This updates the ACLE to support the extension by the introduction of a
new feature macro and the addition of a new possible value to the
existing `__ARM_FEATURE_PAC_DEFAULT` macro.
@@ -362,6 +362,11 @@ Armv8.4-A [[ARMARMv84]](#ARMARMv84). Support is added for the Dot Product intrin
* Added description of SVE reinterpret intrinsics.
* Changes for [Function Multi Versioning](#function-multi-versioning):
* Added [MOPS](#memcpy-family-of-operations-intrinsics---mops).
* Introduced the `__ARM_FEATURE_PAUTH_LR` feature macro in section
[Pointer Authentication](#pointer-authentication) to indicate target support
for the Armv9.5-A's PAC Enhancements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Armv9.5-A's PAC

Remove the possessive apostrophe

Copy link
Contributor

@sallyarmneale sallyarmneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor change

@pratlucas pratlucas deleted the pauth_lr branch April 24, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants