Fix MinGW toolchain install with 'install-llvm-toolchain' #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When MinGW LLVM Embedded Toolchain for Arm is installed using the `install-llvm-toolchain` target, the MinGW-built toolchain executables are not installed under the prefix because `llvm-toolchain-mingw` component is added to the `LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS_ALL` variable, which is never referenced. Fix this by enumerating `LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS_ALL` as intended. Signed-off-by: Stephanos Ioannidis <[email protected]>
dcandler
reviewed
Oct 29, 2024
| @@ -2195,7 +2195,7 @@ set(LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS_ALL ${LLVM_TOOLCHAIN_DISTRIBUTION_COM | |||
| if(LLVM_TOOLCHAIN_CROSS_BUILD_MINGW) | |||
| list(APPEND LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS_ALL llvm-toolchain-mingw) | |||
There was a problem hiding this comment.
Thanks for spotting this.
Looking again at it, I can't see any reason for LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS_ALL to exist it all, and it would make more sense for llvm-toolchain-mingw to be included in LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS instead of creating a duplicate list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When MinGW LLVM Embedded Toolchain for Arm is installed using the
install-llvm-toolchaintarget, the MinGW-built toolchain executables are not installed under the prefix becausellvm-toolchain-mingwcomponent is added to theLLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS_ALLvariable, which is never referenced.Fix this by enumerating
LLVM_TOOLCHAIN_DISTRIBUTION_COMPONENTS_ALLas intended.