-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Update Py-ART to pull colormaps from cmweather #1451
Conversation
zssherman
commented
Sep 7, 2023
- Documentation reflects changes
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only suggestion here would be to add a helpful warning, suggesting that users remove pyart_
in front of their colormap specification. This will likely have breaking changes once we cut a new release.
@mgrover1 Where do you think we should include the warning at? |
I think within the |
@mgrover1 I think either is fine, I'll let you make the decision on that. |
@zssherman - can you make a PR to the new This will ensure that breaking changes go on that branch |
@mgrover1 Sounds good! That PR is now open, closing this one. |