Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update Py-ART to pull colormaps from cmweather #1451

Closed
wants to merge 8 commits into from

Conversation

zssherman
Copy link
Collaborator

  • Documentation reflects changes

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zssherman zssherman requested a review from mgrover1 September 7, 2023 22:17
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only suggestion here would be to add a helpful warning, suggesting that users remove pyart_ in front of their colormap specification. This will likely have breaking changes once we cut a new release.

@zssherman
Copy link
Collaborator Author

@mgrover1 Where do you think we should include the warning at?

@mgrover1
Copy link
Collaborator

mgrover1 commented Sep 8, 2023

I think within the pyart/graph/__init__.py module. One other option here is to create a dedicated Py-ART 2.0 branch, and commit this there, so we can prep for breaking changes. What do you think?

@zssherman
Copy link
Collaborator Author

@mgrover1 I think either is fine, I'll let you make the decision on that.

@mgrover1
Copy link
Collaborator

mgrover1 commented Sep 8, 2023

@zssherman - can you make a PR to the new release/2.0 branch?
https://github.com/ARM-DOE/pyart/tree/release/2.0

This will ensure that breaking changes go on that branch

@zssherman
Copy link
Collaborator Author

@mgrover1 Sounds good! That PR is now open, closing this one.

@zssherman zssherman closed this Sep 8, 2023
@zssherman zssherman deleted the cmweather branch January 23, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants