Fixes to adapt to newest version of ACT #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests need newest version of ACT to pass...passes on my machine with @mgrover1 's branch installed. I will commit for now so that the release can be done. |
johbackm
reviewed
Feb 19, 2024
pysp2/io/read_dat.py
Outdated
There was a problem hiding this comment.
I'm not sure why these edits are not visible in the main branch. I noticed this since I got an AttributeError when trying to do my_binary = pysp2.io.read_dat(dat_file,type='particle') and I got AttributeError: No act.io attribute csvfiles.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some fixes to adapt to the newest version of ACT as well as a more complete unit test for checking the output data.