Factor out fs-metadata and fs-properties crates from fs-storage
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tarek <[email protected]>
Signed-off-by: Tarek <[email protected]>
kirillt
approved these changes
Mar 12, 2024
tareknaser
pushed a commit
to tareknaser/ark-rust
that referenced
this pull request
Mar 12, 2024
* Bump arklib version * Added tokio to deal with futures * Updating the index when links are added * Update GitHub Actions --------- Co-authored-by: Alvi Hysa <[email protected]>
tareknaser
pushed a commit
to tareknaser/ark-rust
that referenced
this pull request
Mar 12, 2024
* Bump arklib version * Added tokio to deal with futures * Updating the index when links are added * Update GitHub Actions --------- Co-authored-by: Alvi Hysa <[email protected]>
Signed-off-by: Tarek <[email protected]>
|
tareknaser
pushed a commit
to tareknaser/ark-rust
that referenced
this pull request
Mar 14, 2024
* Bump arklib version * Added tokio to deal with futures * Updating the index when links are added * Update GitHub Actions --------- Co-authored-by: Alvi Hysa <[email protected]>
The bench feature has been disabled for all crates within the workspace to resolve an issue encountered during CI testing. The reason is that by default, Cargo implicitly adds a libtest benchmark harness to any crate when benchmarking, to handle any #[bench] functions, even if we have none. This ruins our Benchmarking CI with the error (Unrecognized option: save-baseline) in the logs. For more details: https://bheisler.github.io/criterion.rs/book/faq.html#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options Signed-off-by: Tarek <[email protected]>
|
Fixed the issue with the benchmarks CI. The change needs to be in |
kirillt
approved these changes
Mar 16, 2024
tareknaser
pushed a commit
to tareknaser/ark-rust
that referenced
this pull request
Apr 6, 2024
* Bump arklib version * Added tokio to deal with futures * Updating the index when links are added * Update GitHub Actions --------- Co-authored-by: Alvi Hysa <[email protected]>
tareknaser
pushed a commit
to tareknaser/ark-rust
that referenced
this pull request
Apr 6, 2024
* Bump arklib version * Added tokio to deal with futures * Updating the index when links are added * Update GitHub Actions --------- Co-authored-by: Alvi Hysa <[email protected]>
tareknaser
pushed a commit
that referenced
this pull request
Apr 8, 2024
* Bump arklib version * Added tokio to deal with futures * Updating the index when links are added * Update GitHub Actions --------- Co-authored-by: Alvi Hysa <[email protected]>
tareknaser
pushed a commit
to tareknaser/ark-rust
that referenced
this pull request
Apr 9, 2024
* Bump arklib version * Added tokio to deal with futures * Updating the index when links are added * Update GitHub Actions --------- Co-authored-by: Alvi Hysa <[email protected]>
kirillt
added a commit
that referenced
this pull request
Apr 10, 2024
* Bump arklib version * Added tokio to deal with futures * Updating the index when links are added * Update GitHub Actions --------- Co-authored-by: Alvi Hysa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12