-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Automatically switch-on Roots tab on first root pinned. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuancoltech
had a problem deploying
to
Development
February 7, 2024 01:42 — with
GitHub Actions
Failure
tuancoltech
had a problem deploying
to
Development
February 7, 2024 15:17 — with
GitHub Actions
Failure
tuancoltech
force-pushed
the
feature/switch_on_roots_tab
branch
from
February 7, 2024 15:42
b2e2016
to
af3a57e
Compare
tuancoltech
had a problem deploying
to
Development
February 7, 2024 15:42 — with
GitHub Actions
Failure
tuancoltech
force-pushed
the
feature/switch_on_roots_tab
branch
from
February 7, 2024 15:47
af3a57e
to
20718e7
Compare
tuancoltech
had a problem deploying
to
Development
February 7, 2024 15:47 — with
GitHub Actions
Failure
mdrlzy
requested changes
Feb 7, 2024
components/src/main/java/dev/arkbuilders/components/filepicker/ArkFilePickerViewModel.kt
Outdated
Show resolved
Hide resolved
components/src/main/java/dev/arkbuilders/components/filepicker/ArkFilePickerFragment.kt
Outdated
Show resolved
Hide resolved
tuancoltech
force-pushed
the
feature/switch_on_roots_tab
branch
from
February 8, 2024 10:24
20718e7
to
c1928e4
Compare
tuancoltech
had a problem deploying
to
Development
February 8, 2024 10:24 — with
GitHub Actions
Failure
mdrlzy
requested changes
Feb 8, 2024
components/src/main/java/dev/arkbuilders/components/filepicker/ArkFilePickerFragment.kt
Outdated
Show resolved
Hide resolved
components/src/main/java/dev/arkbuilders/components/filepicker/ArkFilePickerFragment.kt
Outdated
Show resolved
Hide resolved
components/src/main/java/dev/arkbuilders/components/filepicker/ArkFilePickerViewModel.kt
Outdated
Show resolved
Hide resolved
components/src/main/java/dev/arkbuilders/components/filepicker/ArkFilePickerViewModel.kt
Outdated
Show resolved
Hide resolved
tuancoltech
force-pushed
the
feature/switch_on_roots_tab
branch
from
February 11, 2024 07:41
be9e7fe
to
9ecda4d
Compare
tuancoltech
temporarily deployed
to
Development
February 11, 2024 07:41 — with
GitHub Actions
Inactive
tuancoltech
force-pushed
the
feature/switch_on_roots_tab
branch
from
February 12, 2024 03:42
9ecda4d
to
fac7db3
Compare
tuancoltech
temporarily deployed
to
Development
February 12, 2024 03:42 — with
GitHub Actions
Inactive
tuancoltech
force-pushed
the
feature/switch_on_roots_tab
branch
from
February 12, 2024 03:46
fac7db3
to
8f47dc0
Compare
tuancoltech
temporarily deployed
to
Development
February 12, 2024 03:46 — with
GitHub Actions
Inactive
tuancoltech
force-pushed
the
feature/switch_on_roots_tab
branch
from
February 12, 2024 10:00
8f47dc0
to
69acb59
Compare
tuancoltech
temporarily deployed
to
Development
February 12, 2024 10:00 — with
GitHub Actions
Inactive
mdrlzy
requested changes
Feb 12, 2024
Comment on lines
486
to
482
popupMenu.setOnMenuItemClickListener { | ||
pinFileCallback?.onPinFileClick(file) | ||
pinFileCallback(file) | ||
true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just viewModel.pinFile(file)
?
components/src/main/java/dev/arkbuilders/components/filepicker/ArkFilePickerViewModel.kt
Outdated
Show resolved
Hide resolved
components/src/main/java/dev/arkbuilders/components/filepicker/ArkFilePickerViewModel.kt
Outdated
Show resolved
Hide resolved
tuancoltech
force-pushed
the
feature/switch_on_roots_tab
branch
from
February 13, 2024 13:45
69acb59
to
476725e
Compare
tuancoltech
temporarily deployed
to
Development
February 13, 2024 13:45 — with
GitHub Actions
Inactive
tuancoltech
force-pushed
the
feature/switch_on_roots_tab
branch
from
February 13, 2024 14:05
476725e
to
fbe88ac
Compare
tuancoltech
temporarily deployed
to
Development
February 13, 2024 14:05 — with
GitHub Actions
Inactive
@mdrlzy Thanks for all your valuable comments. They are very useful. |
hieuwu
reviewed
Feb 14, 2024
components/src/main/java/dev/arkbuilders/components/filepicker/ArkFilePickerViewModel.kt
Outdated
Show resolved
Hide resolved
* [enhance] Remember user's last selected tab Ticket: #51
tuancoltech
force-pushed
the
feature/switch_on_roots_tab
branch
from
February 14, 2024 15:20
fbe88ac
to
79ebca5
Compare
tuancoltech
temporarily deployed
to
Development
February 14, 2024 15:20 — with
GitHub Actions
Inactive
mdrlzy
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
hieuwu
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically switch-on Roots tab on first root pinned
Remember user's last selected tab
Setup deployment pipeline for publishing the
sample
app, which depicts usages of thefilepicker
module.Ticket: #51