Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Automatically switch-on Roots tab on first root pinned. #54

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

tuancoltech
Copy link
Collaborator

@tuancoltech tuancoltech commented Feb 6, 2024

  • Automatically switch-on Roots tab on first root pinned

  • Remember user's last selected tab

  • Setup deployment pipeline for publishing the sample app, which depicts usages of the filepicker module.

Ticket: #51

Comment on lines 486 to 482
popupMenu.setOnMenuItemClickListener {
pinFileCallback?.onPinFileClick(file)
pinFileCallback(file)
true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just viewModel.pinFile(file)?

@tuancoltech
Copy link
Collaborator Author

@mdrlzy Thanks for all your valuable comments. They are very useful.
Please help re-review !

@tuancoltech tuancoltech requested a review from mdrlzy February 13, 2024 14:07
Copy link
Member

@mdrlzy mdrlzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdrlzy mdrlzy merged commit aa70a3e into main Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants