Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample for
ark-core
FileStorage
JNI bindings usage #110base: main
Are you sure you want to change the base?
Sample for
ark-core
FileStorage
JNI bindings usage #110Changes from 7 commits
cc4e896
2ee8c1b
7337904
eb92dfe
8d9d641
4dd2fa7
af5adf8
38380e9
0ea65b5
69c2fba
8bc704f
b2b330b
2d22945
96e8ce8
bf7accc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use
ark-android
to avoid confusion with the archived repo.It was just a fat lib when we were prototyping, now we moved to the next level with modular framework 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I don't know if I understood it correctly. This is indeed a reference to
arklib-android
archive, it is not a name for the current repo. Should we use another repo instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't notice the link leads to the archived repo.
We certainly should not use archived repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But what do we use from
arklib-android
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kirillt It's being used in at least 23 places, just search for
dev.arkbuilders.arklib
and you'll realize it too. Here's an example on thesample
packageark-android/sample/src/main/java/dev/arkbuilders/sample/App.kt
Lines 4 to 6 in 9ab96f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TagSelector
andScoreWidget
dependent on arklib, they needResourceIndex
,TagStorage
,ScoreStorage
and so onThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks guys, I wasn't realizing it.. I'll come up with plan for the upgrade later.