Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust JNI FileStorage bindings sample #109

Closed
wants to merge 5 commits into from
Closed

Rust JNI FileStorage bindings sample #109

wants to merge 5 commits into from

Conversation

oluiscabral
Copy link
Collaborator

This pull request introduces an interactive sample application demonstrating the use of the Rust bindings for the FileStorage, from the fs-storage.

The application features two dialogs:

  1. Root Directory Selection: Allows the user to choose a specific directory as the storage root.
  2. File Scoring Dialog: Enables users to select files from the chosen root directory and assign individual scores to them.

All calculated scores for the selected root directory are then saved to a file named storage.txt located within the same root directory

kirillt
kirillt reviewed Oct 30, 2024
View reviewed changes
sample/src/main/jniLibs/x86_64/libfs_storage.so Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binaries like *.so files should not be committed. Once merge into main, they will cause slower repo cloning, even if we delete them from main later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Let's resolve ARK-Builders/ark-core#92 first, so we can generate both the binaries and the compiled library as well

kirillt
kirillt reviewed Oct 30, 2024
View reviewed changes
sample/src/main/java/dev/arkbuilders/core/FileStorage.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have this file in ark-core/java until we utilize UniFFI.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's related to #109 (comment)

kirillt
kirillt reviewed Oct 30, 2024
View reviewed changes
sample/src/main/java/dev/arkbuilders/core/BTreeMapIterator.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have this file in ark-core/java until we utilize UniFFI.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%. Related to #109 (comment)

@oluiscabral
Copy link
Collaborator Author

Currently, this pull request is awaiting resolution of ARK-Builders/ark-core#92, so the fs-storage binaries and library can be properly imported.

@oluiscabral oluiscabral marked this pull request as draft October 31, 2024 22:15
@oluiscabral oluiscabral force-pushed the fs-storage-jni-bindings branch from c245d44 to c257b9c Compare November 1, 2024 21:39
@oluiscabral
Copy link
Collaborator Author

Closing this Pull Request as I created the branch directly on the repository instead of forking it. Please see the new Pull Request here: #110

@oluiscabral oluiscabral closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillt kirillt kirillt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oluiscabral @kirillt