-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/vitejs svelte #43
Conversation
gwendalF
commented
Sep 18, 2023
•
edited by kirillt
Loading
edited by kirillt
- Move create react app to vitejs #26
…range frontend files
Also removed the static ARK_SHELF_DATA_PATH Added the yarn clean script to clean the cargo cache
Also had incorrect source folder
Bugs:
Correct:
Fine for now:
|
The errors delete panics is because the file is already deleted. It's still see because I have a duplicate key |
run_install: true | ||
|
||
- name: Build Release version | ||
run: pnpm build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be pnpm tauri build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
release.yaml
needs a fix -
./dist
in .gitignore -
The dates are wrong now, not sure what commit caused it, but clearly something happening here:
-
Sort options only work ascending, if you click it again nothing changes.
-
Alphabetically sorting isn't case normalised, so Xero is before alpha
-
"There is already a link with the same URL" does a big redraw of the form at smaller widths, text could just wrap around and not touch the box size. When you go to type in a new link it redraws again.
The sorting is workign as before. I corrected it to use lowercase. If we want to make it works descending I think another PR is better. The date is fixed as the release and dist folder |
All my previous comments are fixed 👍 Only one new issue:
|
@@ -27,30 +28,45 @@ pub enum Mode { | |||
Score, | |||
} | |||
pub type Scores = Vec<Score>; | |||
|
|||
#[derive(Debug, Deserialize, Serialize, PartialEq, PartialOrd, Clone)] | |||
pub struct Score { | |||
pub name: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need name
here?
#[derive(Debug, Deserialize, Serialize, PartialEq, PartialOrd, Clone)] | ||
pub struct Score { | ||
pub name: String, | ||
|
||
pub hash: String, | ||
pub id: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use ResourceId
directly from arklib here?
#[derive(
Eq,
Ord,
PartialEq,
PartialOrd,
Hash,
Clone,
Copy,
Debug,
Deserialize,
Serialize,
)]
pub struct ResourceId {
pub data_size: u64,
pub crc32: u32,
}
Works good, only 2 minor UI issues:
|
There is still a small issue concerning description. But I think we can resolve it with the issue #45 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thanks