-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split app into modules #131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubertm
requested changes
Nov 27, 2024
core/data/src/main/java/dev/arkbuilders/rate/core/data/repo/TimestampRepoImpl.kt
Show resolved
Hide resolved
core/data/src/main/java/dev/arkbuilders/rate/core/data/repo/TimestampRepoImpl.kt
Show resolved
Hide resolved
core/presentation/src/main/java/dev/arkbuilders/rate/core/presentation/ui/DropDown.kt
Show resolved
Hide resolved
Closed
hieuwu
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependencies graph look good & packaging very clean. 👍
SVID_20241203_151830_1.mp4
|
shubertm
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules structure
Resources
All resources are located in
:core:presentation
. Keeping resources in feature modules and ensuring that they are not duplicated will be a mess. We can easily access them via type aliases.Navigation
Feature modules generate compose-destination classes. We collect them in app module and create a single graph manually.
compose-destinations
library works in destinations modeDI
We have
CoreComponent
in:core:di
that contains common dependencies withSingleton
scope. Feature modules create own components that depend onCoreComponent
with own scopes. App holdsCoreComponent
and provides it.Feature component are stored in separate object called
FeatureComponentHolder
inside the module. This is the easiest way to reuse component between compose screens in module.Notes
:core:di
and:core:db
needed to not expose:core:data
module and implementation so feature modules only know about:core:domain
and interfacesBuildConfigFields
andBuildConfigFieldsProvider
.BuildConfigFieldsProvider
created in:core:data
module and initialized in app module. So all modules can use the build config of app module.