Add basic rate conversion #3

virtualdesigner · 2023-09-03T06:59:38Z

Added minimal prototype as mentioned in the issue #1

Screen.Recording.2023-09-03.at.12.26.56.PM.mov

Auto-focus search input

Add default text when no asset is added

Make the Tabs re-usable

Change root name of the app

kirillt · 2023-09-03T16:25:39Z

Thank you @virtualdesigner, could you also provide detailed build instructions in README?

I try this:

yarn
yarn tauri dev

But it crashes:

The following warnings were emitted during compilation:

warning: `PKG_CONFIG_ALLOW_SYSTEM_CFLAGS="1" "pkg-config" "--libs" "--cflags" "javascriptcoregtk-4.1" "javascriptcoregtk-4.1 >= 2.38"` did not exit successfully: exit status: 1

error: failed to run custom build command for `javascriptcore-rs-sys v1.0.0`

Caused by:
  process didn't exit successfully: `/tmp/ARK-Builders/ARK-Rate-Desktop/src-tauri/target/debug/build/javascriptcore-rs-sys-6f7b0409cd3c8a1b/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=JAVASCRIPTCOREGTK_4.1_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  cargo:warning=`PKG_CONFIG_ALLOW_SYSTEM_CFLAGS="1" "pkg-config" "--libs" "--cflags" "javascriptcoregtk-4.1" "javascriptcoregtk-4.1 >= 2.38"` did not exit successfully: exit status: 1
  error: could not find system library 'javascriptcoregtk-4.1' required by the 'javascriptcore-rs-sys' crate

  --- stderr
  Package javascriptcoregtk-4.1 was not found in the pkg-config search path.
  Perhaps you should add the directory containing `javascriptcoregtk-4.1.pc'
  to the PKG_CONFIG_PATH environment variable
  Package 'javascriptcoregtk-4.1', required by 'virtual:world', not found
  Package 'javascriptcoregtk-4.1', required by 'virtual:world', not found

warning: build failed, waiting for other jobs to finish...

error Command failed with exit code 101.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

virtualdesigner · 2023-09-04T03:57:42Z

Thank you @virtualdesigner, could you also provide detailed build instructions in README?

I try this:

yarn
yarn tauri dev

But it crashes:

The following warnings were emitted during compilation:

warning: `PKG_CONFIG_ALLOW_SYSTEM_CFLAGS="1" "pkg-config" "--libs" "--cflags" "javascriptcoregtk-4.1" "javascriptcoregtk-4.1 >= 2.38"` did not exit successfully: exit status: 1

error: failed to run custom build command for `javascriptcore-rs-sys v1.0.0`

Caused by:
  process didn't exit successfully: `/tmp/ARK-Builders/ARK-Rate-Desktop/src-tauri/target/debug/build/javascriptcore-rs-sys-6f7b0409cd3c8a1b/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=JAVASCRIPTCOREGTK_4.1_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  cargo:warning=`PKG_CONFIG_ALLOW_SYSTEM_CFLAGS="1" "pkg-config" "--libs" "--cflags" "javascriptcoregtk-4.1" "javascriptcoregtk-4.1 >= 2.38"` did not exit successfully: exit status: 1
  error: could not find system library 'javascriptcoregtk-4.1' required by the 'javascriptcore-rs-sys' crate

  --- stderr
  Package javascriptcoregtk-4.1 was not found in the pkg-config search path.
  Perhaps you should add the directory containing `javascriptcoregtk-4.1.pc'
  to the PKG_CONFIG_PATH environment variable
  Package 'javascriptcoregtk-4.1', required by 'virtual:world', not found
  Package 'javascriptcoregtk-4.1', required by 'virtual:world', not found

warning: build failed, waiting for other jobs to finish...

error Command failed with exit code 101.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@kirillt I've added some instructions to install the app. We need to install some OS-specific dependencies before getting started. Can you please try out the steps and let me know how it goes?

kirillt · 2023-09-04T04:16:55Z

@virtualdesigner the steps seem to be the same (yarn and yarn tauri dev). Do I need to install Tauri Bundler? That's something new, I guess, since it wasn't necessary before (https://github.com/ARK-Builders/ark-shelf-desktop).

kirillt · 2023-09-04T04:25:31Z

It seems that the bundler is only needed for building a package. Right now, yarn tauri dev crashes, so I can't run the project.

But the video looks cool!

virtualdesigner · 2023-09-04T05:54:51Z

@kirillt I've added more details in the readme for installing the prerequisites.
From the error message, I guess you'd need to install the missing package javascriptcore-rs-sys.

kirillt · 2023-09-04T06:30:17Z

Thanks @virtualdesigner, now it's good. On my laptop it's still crashing, but I believe it's something specific to my installation of Fedora Linux.

I think we should complete these 2 steps before merge:

Create GitHub Actions scripts to build the package,
see https://github.com/ARK-Builders/ARK-Shelf-Desktop/actions
Move core logic from JavaScript to Rust

kirillt · 2023-09-04T06:49:10Z

For Linux, AppImage is fine (no need to build .dep or .rpm). I'm not sure about Windows and macOS, is it same complexity? @virtualdesigner

src-tauri/src/lib.rs

package.json

public/tauri.svg

src-tauri/Cargo.toml

src-tauri/src/lib.rs

src/context/CurrencyContext.tsx

Configure Rust to be a binary instead of a library build

Divide the logic into separate files

kirillt · 2023-09-16T16:49:57Z

Latest AppImage can't start with this error:

`Err` value: Os { code: 30, kind: ReadOnlyFilesystem, message: "Read-only file system" }'

kirillt · 2023-09-23T06:27:47Z

@virtualdesigner It worked on my laptop, great!

Could you also update .github/workflows/build.yml?

Bump version of actions/checkout
Replace deprecated actions-rs/toolchain with newer dtolnay/rust-toolchain

Here is an example: https://github.com/ARK-Builders/ARK-Shelf-Desktop/blob/main/.github/workflows/build.yml

kirillt

Good job, thanks

virtualdesigner added 7 commits September 2, 2023 19:23

Add basic rate conversion

21fb372

Make search independent of the text case,

ca44978

Auto-focus search input

Get rid of duplicates between fiat and crypto rates

47b24c0

Rectify calculations,

5763e84

Add default text when no asset is added

Make the close button bolder,

42aead9

Make the Tabs re-usable

Auto-detect current tab

afa47ff

Limit decimal precision to 8 digits

3a61d4b

virtualdesigner requested a review from kirillt September 3, 2023 06:59

virtualdesigner self-assigned this Sep 3, 2023

virtualdesigner added 3 commits September 3, 2023 12:49

Reset existing amount to zero if deselected,

ee5b176

Change root name of the app

Remove unnecessary file

9f3a33e

Remove unused style

3930d03

virtualdesigner added 2 commits September 4, 2023 09:24

Add installation and build instructions

df2f329

Change identifier

955a450

Add more details on the readme for installing the prerequisites

7050723

Add github workflow scripts for build and release

e9c45cd

virtualdesigner added 5 commits September 4, 2023 12:34

Limit build targets to "msi", "app" & "dmg"

dd37796

Remove uploading .deb & binary files

4797ed0

Add missing library to install during the build

67f23c4

Add missing dependency to install

d0c48b7

Move currency total calculation and exchange calculation to Rust

c8c9f19

kirillt reviewed Sep 5, 2023

View reviewed changes

src-tauri/src/lib.rs Outdated Show resolved Hide resolved

gwendalF reviewed Sep 5, 2023

View reviewed changes

virtualdesigner added 10 commits September 9, 2023 16:10

Downgrade to a stable version of Tauri,

4f8a297

Configure Rust to be a binary instead of a library build

Change workflow build dependency

90d09ac

Add type for children node

e2888b4

Fetch rates from Rust,

923eadf

Divide the logic into separate files

Remove package in build workflow

8e6967c

Add missing package in build workflow

cedc566

Change config for build workflow

3dbd7f9

Fix image bundle name

0c6f0bc

Change path for artifact

45dfc1e

Use the rates data provided by Rust code

1381c13

virtualdesigner added 3 commits September 18, 2023 18:29

Replace default icons

6b2fa5d

Add URL strings to the top of the file

ecf3fb4

Use directories crate to store the rates

f97821f

kirillt requested a review from gwendalF September 23, 2023 06:27

virtualdesigner added 3 commits September 23, 2023 13:54

Bump actions/checkout package & use newer toolchain to install Rust

ef96fd8

Refactor data fetch and storage

a1db788

Add test cases

0510b6a

kirillt self-requested a review September 24, 2023 15:00

kirillt approved these changes Sep 24, 2023

View reviewed changes

kirillt merged commit 3c35c67 into main Sep 24, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic rate conversion #3

Add basic rate conversion #3

virtualdesigner commented Sep 3, 2023

kirillt commented Sep 3, 2023

virtualdesigner commented Sep 4, 2023

kirillt commented Sep 4, 2023

kirillt commented Sep 4, 2023 •

edited

Loading

virtualdesigner commented Sep 4, 2023 •

edited

Loading

kirillt commented Sep 4, 2023 •

edited

Loading

kirillt commented Sep 4, 2023

kirillt commented Sep 16, 2023

kirillt commented Sep 23, 2023 •

edited by virtualdesigner

Loading

kirillt left a comment

Add basic rate conversion #3

Add basic rate conversion #3

Conversation

virtualdesigner commented Sep 3, 2023

kirillt commented Sep 3, 2023

virtualdesigner commented Sep 4, 2023

kirillt commented Sep 4, 2023

kirillt commented Sep 4, 2023 • edited Loading

virtualdesigner commented Sep 4, 2023 • edited Loading

kirillt commented Sep 4, 2023 • edited Loading

kirillt commented Sep 4, 2023

kirillt commented Sep 16, 2023

kirillt commented Sep 23, 2023 • edited by virtualdesigner Loading

kirillt left a comment

Choose a reason for hiding this comment

kirillt commented Sep 4, 2023 •

edited

Loading

virtualdesigner commented Sep 4, 2023 •

edited

Loading

kirillt commented Sep 4, 2023 •

edited

Loading

kirillt commented Sep 23, 2023 •

edited by virtualdesigner

Loading