[enhancement] Fix Lint warnings #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuancoltech
temporarily deployed
to
Development
GitHub Actions
Inactive
tuancoltech
changed the title
tuancoltech
temporarily deployed
to
Development
GitHub Actions
Inactive
tuancoltech
had a problem deploying
to
Development
GitHub Actions
Failure
tuancoltech
temporarily deployed
to
Development
GitHub Actions
Inactive
… * Add task configuration avoidance by using register when define a gradle task * Update protected visibility in final class to private as they are effectively the same * Add private modifier for variables where needed * Upgrade kotlin version & kotlin gradle plugin to 1.8.20 * Naming issues and others
tuancoltech
force-pushed
the
enhance/fix_lint_warnings
branch
from
2688a23 to
5e97b46
Compare
tuancoltech
temporarily deployed
to
Development
GitHub Actions
Inactive
|
Kudos, SonarCloud Quality Gate passed!
|
tuancoltech
temporarily deployed
to
Development
GitHub Actions
Inactive
tuancoltech
temporarily deployed
to
Development
GitHub Actions
Inactive
tuancoltech
temporarily deployed
to
Development
GitHub Actions
Inactive
kirillt
reviewed
Oct 24, 2023
app/src/main/java/dev/arkbuilders/navigator/data/stats/PlainStatsStorage.kt
Show resolved
Hide resolved
kirillt
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Lint warnings: #405
🚀 Summary
Fix Lint warnings including:
🖼️ Screenshots:
| Before |
| After |